Skip to content

Add support for STM32F407x MCUs. #13718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 8, 2021
Merged

Add support for STM32F407x MCUs. #13718

merged 6 commits into from
Aug 8, 2021

Conversation

thpoll83
Copy link

Add support for STM32F407xE (512KB) and STM32F407xG (1MB) MCUs.

Description

Extended the build and python files to support these two STM32F407 MCU variations using the ST_STM32F4_DISCOVERY (STM32F407xG) board files. The mcuconf.h already existed in ChibiOS.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • [ x] Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • [ x] I have read the PR Checklist document and have made the appropriate changes.
  • [ x] My change requires a change to the documentation.
  • [ x] I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested review from tzarc and a team July 26, 2021 20:18
fauxpark
fauxpark requested changes Jul 26, 2021
View reviewed changes
tzarc
tzarc requested changes Jul 26, 2021
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please move platforms/chibios/GENERIC_STM32_F407VG to platforms/chibios/GENERIC_STM32_F407XE -- in general the preference is to provide the "base" version and allow people to override the size through an ldscript override in their rules.mk -- otherwise the core side of things ends up blowing out considerably.

I'll retarget to the develop branch because it's core-related, and not a bugfix. Looks like you'll need to rebase -- apologies for that.

@tzarc tzarc changed the base branch from master to develop July 26, 2021 20:45
tzarc
tzarc reviewed Jul 26, 2021
View reviewed changes
@github-actions github-actions bot removed the keymap label Aug 2, 2021
@thpoll83
Copy link
Author

thpoll83 commented Aug 2, 2021

Alright, I rebased to develop and applied all suggestions.

@tzarc
Copy link
Member

tzarc commented Aug 2, 2021

Looks like a couple of cannonkeys files were unintentionally modified -- if we can get that rectified this looks good to go.

tzarc
tzarc reviewed Aug 2, 2021
View reviewed changes
@github-actions github-actions bot removed the keyboard label Aug 2, 2021
@thpoll83 thpoll83 requested review from tzarc and fauxpark August 3, 2021 05:51
@thpoll83
Copy link
Author

thpoll83 commented Aug 4, 2021

Can you please check the PR again?

@tzarc
Copy link
Member

tzarc commented Aug 7, 2021

Can you please check the PR again?

USART2 change still hasn't been applied, I'm afraid.

@thpoll83 @drashna
Update platforms/chibios/GENERIC_STM32_F407XE/configs/mcuconf.h
74adc87 
Co-authored-by: Drashna Jaelre <drashna@live.com>
tzarc
tzarc reviewed Aug 8, 2021
View reviewed changes
@tzarc tzarc merged commit b43c6bc into qmk:develop Aug 8, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@thpoll83 @fauxpark
@drashna @tzarc @nhongooi
Add support for STM32F407x MCUs. (qmk#13718)
8219400 
* Add support for STM32F407x MCUs.

* Removing STMF407 MCU variation

* Update quantum/mcu_selection.mk

Remove options for dfu flashing

Co-authored-by: Ryan <fauxpark@gmail.com>

* DISABLE STM32_USB_USE_OTG1

* Update platforms/chibios/GENERIC_STM32_F407XE/configs/mcuconf.h

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Update platforms/chibios/GENERIC_STM32_F407XE/configs/mcuconf.h

Co-authored-by: thomas.pollak <thomas.pollak@dynatrace.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Nick Brassel <nick@tzarc.org>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@thpoll83 @fauxpark
@drashna @tzarc
Add support for STM32F407x MCUs. (qmk#13718)
4d72699 
* Add support for STM32F407x MCUs.

* Removing STMF407 MCU variation

* Update quantum/mcu_selection.mk

Remove options for dfu flashing

Co-authored-by: Ryan <fauxpark@gmail.com>

* DISABLE STM32_USB_USE_OTG1

* Update platforms/chibios/GENERIC_STM32_F407XE/configs/mcuconf.h

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Update platforms/chibios/GENERIC_STM32_F407XE/configs/mcuconf.h

Co-authored-by: thomas.pollak <thomas.pollak@dynatrace.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@tzarc tzarc tzarc approved these changes

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
cli qmk cli command core documentation python translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thpoll83 @tzarc @drashna @fauxpark @zvecr