Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for STM32F407x MCUs. #13718

Merged
merged 6 commits into from
Aug 8, 2021
Merged

Add support for STM32F407x MCUs. #13718

merged 6 commits into from
Aug 8, 2021

Conversation

thpoll83
Copy link

Add support for STM32F407xE (512KB) and STM32F407xG (1MB) MCUs.

Description

Extended the build and python files to support these two STM32F407 MCU variations using the ST_STM32F4_DISCOVERY (STM32F407xG) board files. The mcuconf.h already existed in ChibiOS.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • [ x] Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • [ x] I have read the PR Checklist document and have made the appropriate changes.
  • [ x] My change requires a change to the documentation.
  • [ x] I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

quantum/mcu_selection.mk Outdated Show resolved Hide resolved
quantum/mcu_selection.mk Outdated Show resolved Hide resolved
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please move platforms/chibios/GENERIC_STM32_F407VG to platforms/chibios/GENERIC_STM32_F407XE -- in general the preference is to provide the "base" version and allow people to override the size through an ldscript override in their rules.mk -- otherwise the core side of things ends up blowing out considerably.

I'll retarget to the develop branch because it's core-related, and not a bugfix. Looks like you'll need to rebase -- apologies for that.

data/schemas/keyboard.jsonschema Outdated Show resolved Hide resolved
lib/python/qmk/constants.py Outdated Show resolved Hide resolved
platforms/chibios/GENERIC_STM32_F407VG/configs/config.h Outdated Show resolved Hide resolved
platforms/chibios/GENERIC_STM32_F407VG/configs/mcuconf.h Outdated Show resolved Hide resolved
quantum/mcu_selection.mk Outdated Show resolved Hide resolved
quantum/mcu_selection.mk Outdated Show resolved Hide resolved
quantum/mcu_selection.mk Outdated Show resolved Hide resolved
@tzarc tzarc changed the base branch from master to develop July 26, 2021 20:45
@thpoll83
Copy link
Author

thpoll83 commented Aug 2, 2021

Alright, I rebased to develop and applied all suggestions.

@tzarc
Copy link
Member

tzarc commented Aug 2, 2021

Looks like a couple of cannonkeys files were unintentionally modified -- if we can get that rectified this looks good to go.

@thpoll83
Copy link
Author

thpoll83 commented Aug 4, 2021

Can you please check the PR again?

@tzarc
Copy link
Member

tzarc commented Aug 7, 2021

Can you please check the PR again?

USART2 change still hasn't been applied, I'm afraid.

Co-authored-by: Drashna Jaelre <drashna@live.com>
@tzarc tzarc merged commit b43c6bc into qmk:develop Aug 8, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Aug 9, 2021
* qmk/develop: (175 commits)
  Add support for STM32F407x MCUs. (qmk#13718)
  [Keyboard] Add Pancake v2 (qmk#13839)
  [Keyboard] Added CapsLED and ScrollLock LEDs (qmk#13837)
  [Keymap] Drashna split transport improvement (qmk#13905)
  [Keyboard] a1200 converter minor changes (qmk#13848)
  [Keyboard] Gorthage Truck - New PCB (qmk#13909)
  [Keyboard] Clean up lfkpad and add keymap (qmk#13881)
  [Keyboard] Adding my Nyquist keymap (qmk#13858)
  [Keyboard] Fix matrix_output_unselect_delay for handwired/xealousbrown (qmk#13913)
  [Keyboard] fixes for KBD67 rev2 (qmk#13906)
  Clean up remaining RGB_DISABLE_WHEN_USB_SUSPENDED defines Part 2 (qmk#13912)
  Refactor `quantum/command.{c,h}` for code size & {read,maintain}ability (qmk#11842)
  Remove Full Bootmagic (qmk#13846)
  [Keyboard] Added 67mk_E PCB (qmk#13869)
  [Keyboard] Modify key drive pins for mojo68 (qmk#13863)
  [Keyboard] Use new matrix_output_select_delay api (qmk#13861)
  [Keyboard] add handwired/oem_ansi_fullsize (qmk#13857)
  [Keymap] JackKenney's keymap for GMMK Pro (qmk#13853)
  [Keyboard] Fix oled_task_user for chocolatebar (qmk#13911)
  clean up CRLF instances (qmk#13910)
  ...
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
* Add support for STM32F407x MCUs.

* Removing STMF407 MCU variation

* Update quantum/mcu_selection.mk

Remove options for dfu flashing

Co-authored-by: Ryan <fauxpark@gmail.com>

* DISABLE STM32_USB_USE_OTG1

* Update platforms/chibios/GENERIC_STM32_F407XE/configs/mcuconf.h

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Update platforms/chibios/GENERIC_STM32_F407XE/configs/mcuconf.h

Co-authored-by: thomas.pollak <thomas.pollak@dynatrace.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Nick Brassel <nick@tzarc.org>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Add support for STM32F407x MCUs.

* Removing STMF407 MCU variation

* Update quantum/mcu_selection.mk

Remove options for dfu flashing

Co-authored-by: Ryan <fauxpark@gmail.com>

* DISABLE STM32_USB_USE_OTG1

* Update platforms/chibios/GENERIC_STM32_F407XE/configs/mcuconf.h

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Update platforms/chibios/GENERIC_STM32_F407XE/configs/mcuconf.h

Co-authored-by: thomas.pollak <thomas.pollak@dynatrace.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants