Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ISSI drivers on both sides of a split keyboard #13842

Merged
merged 21 commits into from
Nov 1, 2021
Merged

Add support for ISSI drivers on both sides of a split keyboard #13842

merged 21 commits into from
Nov 1, 2021

Commits on Sep 25, 2021

  1. Gets RGB working on a split keyboard with IS31FL3733. Currently needs… 

    … small tweak to re-enable WS2812
    Vlad Kvitnevskiy committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    ccc6f99 View commit details
    Browse the repository at this point in the history

  2. Added helper function

    Vlad Kvitnevskiy committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    8cfdc33 View commit details
    Browse the repository at this point in the history

  3. Trying to integrate the function

    Vlad Kvitnevskiy committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    d2f192c View commit details
    Browse the repository at this point in the history

  4. Moved functionality into a macro

    Vlad Kvitnevskiy committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    f81a5c4 View commit details
    Browse the repository at this point in the history

  5. Swapped conditional for a macro everywhere

    Vlad Kvitnevskiy committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    545d238 View commit details
    Browse the repository at this point in the history

  6. Tidying up

    Vlad Kvitnevskiy committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    534b31a View commit details
    Browse the repository at this point in the history

  7. More code cleanup

    Vlad Kvitnevskiy committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    84ff177 View commit details
    Browse the repository at this point in the history

  8. Documentation updates

    Vlad Kvitnevskiy committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    ca99f74 View commit details
    Browse the repository at this point in the history

  9. Fixed formatting via linter

    Vlad Kvitnevskiy committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    1174ee4 View commit details
    Browse the repository at this point in the history

  10. Switching to a function from a macro

    Vlad Kvitnevskiy committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    e9a2b82 View commit details
    Browse the repository at this point in the history

  11. Fixed compile error

    Vlad Kvitnevskiy committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    e9ccc0c View commit details
    Browse the repository at this point in the history

  12. Fixing WS2812 behavior. UNTESTED.

    Vlad Kvitnevskiy committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    c709b62 View commit details
    Browse the repository at this point in the history

  13. Updated documentation about the driver addresses.

    Vlad Kvitnevskiy committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    eff63d3 View commit details
    Browse the repository at this point in the history

  14. Fixed code for WS2812

    Vlad Kvitnevskiy committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    2b2bdc1 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2021

  1. Trying to add in LED_MATRIX support

    Vlad Kvitnevskiy committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    9d70700 View commit details
    Browse the repository at this point in the history

  2. Updated effects for LED matrix

    Vlad Kvitnevskiy committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    436175c View commit details
    Browse the repository at this point in the history

  3. Updated third-party effect defines.

    Vlad Kvitnevskiy committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    3e8086b View commit details
    Browse the repository at this point in the history

  4. Ran format-c on modified files

    Vlad Kvitnevskiy committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    4162c31 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Ryan <fauxpark@gmail.com>
    @vladkvit @fauxpark
    vladkvit and fauxpark committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    ea16bc0 View commit details
    Browse the repository at this point in the history

  6. Move to static inline. Avoids issues with gcc v8+

    Vlad Kvitnevskiy committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    4937eeb View commit details
    Browse the repository at this point in the history

  7. Move helper function for LED_matrix to static inline to avoid issues … 

    …with gcc v8+
    Vlad Kvitnevskiy committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    f534ff0 View commit details
    Browse the repository at this point in the history