Enable de-ghosting for RGB/LED matrix on all ISSI LED drivers #14508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 2, 2021 17:58
|
No support for the 3731? (I'm pretty sure the answer is no). Also, the 3218? |
|
Not that I can tell from looking at the datasheets. I didn't see any mention of de-ghosting built into the array. |
|
Actually the application note for 3731 mentions “0xC2 Ghost Image Prevention Register” in section Q20; for some reason the 3731 datasheet does not describe that register. |
|
Why the hell is that not in the datasheet.... Thanks for the heads up @sigprof, I'll add that in! It's a boolean for enabling the de-ghost on or off so I'm gonna have to setup a special define just for that IC |
drashna
approved these changes
Sep 24, 2021
tzarc
approved these changes
Nov 1, 2021
|
Conflicts need to be resolved, other than that looks fine. |
ptrxyz
pushed a commit
to ptrxyz/qmk_firmware
that referenced
this pull request
Apr 9, 2022
) * Initial work for de-ghost enable * Dumb mistake with the redefine * Added Copywrite stuff on source files * Fixed whitespace errors * Added support for all ISSI LED drivers * Updated docs for support for ISSI LED driver pull-up pull-down * Applied clang format * Added 'boolean' flag to enable de-ghosting for the is31fl3731 IC * Fixed some of the grammer in the docs * Fixed comment placement and grammer of comment * Fixed whitespace errors from lint Co-authored-by: donicrosby <donicrosby1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take two of #14281
Description
Currently RGB/LED matrixes for the various ISSI ICs have ghosting issues with the LEDs. Any LEDs used as indicators or just plain off in the matrix glow faintly which isn't ideal. I have added a option to be set in a keyboards config.h that allows for makers and users to enable the de-ghosting functions of the ICs for all of the drivers on the board so that this ghosting is eliminated.
I have set the default value to allow for ghosting (0 ohm resistor/de-ghosting settings off) so as to stay backwards compatible and not cause power issues with older boards.
The datasheet recommends enabling the highest resistor possible during the blanking time so there shouldn't be any dimming with the LEDs when they are on. If you want me to set that as the default (would make sense that you wouldn't want ghosting on the matrix) I can do that as well.
Types of Changes
Issues Fixed or Closed by This PR
Checklist