New combo configuration options #15083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`COMBO_MUST_PRESS_IN_ORDER` to force combos to only activate if the keys are pressed in the same order as they are defined in the combo's key array. Per combo configuration can be modified by defining `COMBO_MUST_PRESS_IN_ORDER_PER_COMBO` and defining `bool get_combo_must_press_in_order(uint16_t combo_index, combo_t *combo, uint16_t keycode, keyrecord_t *record)` function in which you choose which combos require the correct key order. `COMBO_SHOULD_TRIGGER` and its companying function `bool combo_should_trigger(uint16_t combo_index, combo_t *combo, uint16_t keycode, keyrecord_t *record)` enable disallowing combos to be activated when you choose so. For example on certain layers, or when a timer is running.
sevanteri
force-pushed
the
combo_key_order
branch
from
af13eef to
7e1f9b3
Compare
tzarc
approved these changes
Dec 27, 2021
precondition
reviewed
Jan 1, 2022
Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
sevanteri
force-pushed
the
combo_key_order
branch
from
1f418d0 to
b81b52b
Compare
|
Submodule changes need to be rolled back. |
The one time I think |
sevanteri
force-pushed
the
combo_key_order
branch
from
b81b52b to
0d3198b
Compare
drashna
approved these changes
Jan 9, 2022
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here's a couple of new configuration features for combos.
COMBO_MUST_PRESS_IN_ORDERto force combos to only activate if the keys are pressed in the same order as they are defined in the combo's key array.Per combo configuration can be modified by defining
COMBO_MUST_PRESS_IN_ORDER_PER_COMBOand definingbool get_combo_must_press_in_order(uint16_t combo_index, combo_t *combo, uint16_t keycode, keyrecord_t *record)function in which you choose which combos require the correct key order.This feature even allows multiple combos from the same keys. For example on qwerty layout,
JKcan produce/andKJcan produce\. Just define two combos using the same keys but put the keycodes in reverse order for the other one.COMBO_SHOULD_TRIGGERand its companying functionbool combo_should_trigger(uint16_t combo_index, combo_t *combo, uint16_t keycode, keyrecord_t *record)enable disallowing combos to be activated when you choose so. Forexample on certain layers, or when a timer is running.
Types of Changes
Checklist