Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend tap code delay for macOS #15200

Closed
wants to merge 3 commits into from
Closed

Recommend tap code delay for macOS #15200

wants to merge 3 commits into from

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Nov 18, 2021 •
edited
Loading

Description

Recommend an optimal TAP_CODE_DELAY for OS X

Types of Changes

  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team November 28, 2021 08:33
fauxpark
fauxpark reviewed Nov 29, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not already handled by TAP_HOLD_CAPS_DELAY?

@filterpaper
Copy link
Contributor Author

I tested it again and confirmed that default TAP_HOLD_CAPS_DELAY 80 is sufficient for the macOS to distinguish between language switching and long-press capitalisation.

@filterpaper filterpaper deleted the macos-tapcodedelay branch November 29, 2021 13:13
@cythb cythb mentioned this pull request Dec 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark left review comments

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Capslock toggle Chinese and English on macOS
2 participants
@filterpaper @fauxpark