Meridian LED update #15329
Merged
Meridian LED update #15329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Nov 28, 2021
tzarc
approved these changes
Nov 28, 2021
rudism
pushed a commit
to rudism/qmk_firmware
that referenced
this pull request
Jan 16, 2022
* Meridian first update * Update README, adjust timing settings * Update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Meridian PCB suffered a logistics/communication issue and some units were shipped with KTR1010 LEDs which are wildly out of timing when compared to the default WS2812 LEDs. In this regard, this firmware update makes use of the recent "ajustable timing parameters" recently merged into master from these PRs:
#14678
#15298
#15299
The updated firmware has two options,
ws2812andktr1010which compiling and flashing are explained in the readme.Firmware-wise the difference between these options is that while the
ws2812option uses the common SPI driver with default timings, thektr1010options uses the bit-banged driver with the adjusted timing parameters. The PCB suffers no noticeable problems stemming from the bit-bang usage since it has only three RGB LEDs used for indicators.Types of Changes
Issues Fixed or Closed by This PR
Not exactly fixed or closed but this PR fulfills the initial intent of the PR lineage mentioned in the description: officially supporting the Meridian KTR1010 PCBs.
Checklist