Combo TAP_CODE_DELAY and clear_weak_mods
#15866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some software don't like key press and release events too close to each other, so a delay is needed after dumping the key buffer in combo processing.
Before, weak mods from combos could leak to the next key press if pressed too fast.
|
Why does "some software" have to suck so bad... I hate having |
drashna
approved these changes
Jan 13, 2022
|
Needs some work still. If a mod-tap or similar is part of a combo, the delay is applied twice after releasing the key (once in combo processing, once in the |
tzarc
approved these changes
Jan 16, 2022
Is this ready to go, as is? |
|
Yeah, should be good to go, haven't had problems with it. |
drashna
approved these changes
Jan 29, 2022
uvera
pushed a commit
to uvera/qmk_firmware
that referenced
this pull request
Dec 14, 2022
Signed-off-by: Dušan <dusan.uveric@mitigate.dev>
uvera
pushed a commit
to uvera/qmk_firmware
that referenced
this pull request
Dec 14, 2022
Signed-off-by: Dušan <dusan.uveric@mitigate.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TAP_CODE_DELAY: Some software (e.g. some games) don't like key press and release events too close to each other, so a delay is needed after dumping the key buffer in combo processing.clear_weak_mods: Before, weak mods from combos could leak to the next key press if pressed too fast.Types of Changes
Checklist