Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename some Quantum keycodes #15968

Merged
merged 2 commits into from Jan 22, 2022
Merged

Rename some Quantum keycodes #15968

merged 2 commits into from Jan 22, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jan 21, 2022 •
edited

Description

Part of an effort to normalise keycode names.

Renamed keycodes:

Old Keycode New Keycode
RESET QK_BOOTLOADER
DEBUG QK_DEBUG_TOGGLE
GRAVE_ESC QK_GRAVE_ESCAPE
EEPROM_RESET QK_CLEAR_EEPROM

Added aliases:

Alias Keycode
QK_BOOT QK_BOOTLOADER
DB_TOGG QK_DEBUG_TOGGLE
EE_CLR QK_CLEAR_EEPROM
QK_GESC QK_GRAVE_ESCAPE

Removed aliases:

Alias Replacement
EEP_RST EE_CLR
KC_GESC QK_GESC

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team January 21, 2022 02:26
drashna
drashna approved these changes Jan 21, 2022
View reviewed changes
quantum/quantum_keycodes.h Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team January 21, 2022 02:36
@fauxpark fauxpark requested a review from drashna January 21, 2022 15:55
@drashna drashna requested a review from a team January 22, 2022 02:00
@zvecr zvecr merged commit b45a037 into qmk:develop Jan 22, 2022
@fauxpark fauxpark deleted the simple-quantum-keycodes-deprecation branch January 22, 2022 03:38
@drashna drashna mentioned this pull request Jan 22, 2022
Merged
10 tasks
@fauxpark fauxpark mentioned this pull request Jan 22, 2022
Merged
14 tasks
@KarlK90 KarlK90 mentioned this pull request Mar 14, 2022
Closed
0xcharly added a commit to Bastardkb/bastardkb-qmk that referenced this pull request Nov 27, 2022
@0xcharly
Replace EEP_RST with EE_CLR
fb5ad1a 
`EEP_RST` is deprecated and should be replaced with `EE_CLR`.

Deprecated in qmk#15968.

Fixes #34.
0xcharly added a commit to Bastardkb/bastardkb-qmk that referenced this pull request Nov 27, 2022
@0xcharly
Replace EEP_RST with EE_CLR
25cb150 
`EEP_RST` is deprecated and should be replaced with `EE_CLR`.

Deprecated in qmk#15968.

Fixes #34.
0xcharly added a commit to Bastardkb/bastardkb-qmk that referenced this pull request Nov 28, 2022
@0xcharly
Replace EEP_RST with EE_CLR
af09c22 
`EEP_RST` is deprecated and should be replaced with `EE_CLR`.

Deprecated in qmk#15968.

Fixes #34.
0xcharly added a commit to Bastardkb/bastardkb-qmk that referenced this pull request Dec 2, 2022
@0xcharly
Replace EEP_RST with EE_CLR
b4246e8 
`EEP_RST` is deprecated and should be replaced with `EE_CLR`.

Deprecated in qmk#15968.

Fixes #34.
0xcharly added a commit to Bastardkb/bastardkb-qmk that referenced this pull request Dec 30, 2022
@0xcharly
Replace EEP_RST with EE_CLR
89b1fbf 
`EEP_RST` is deprecated and should be replaced with `EE_CLR`.

Deprecated in qmk#15968.

Fixes #34.
fcatt added a commit to fcatt/yacobo that referenced this pull request Jan 6, 2023
@fcatt
[firmware] replace KC_RST with QK_BOOT (qmk/qmk_firmware#15968)
fa867c6
Nsidorenco pushed a commit to Nsidorenco/qmk_firmware that referenced this pull request Jan 8, 2023
@0xcharly @nsi-inco
Replace EEP_RST with EE_CLR
2914268 
`EEP_RST` is deprecated and should be replaced with `EE_CLR`.

Deprecated in qmk#15968.

Fixes qmk#34.
0xcharly added a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jan 22, 2023
@0xcharly
Replace EEP_RST with EE_CLR
dba45f9 
`EEP_RST` is deprecated and should be replaced with `EE_CLR`.

Deprecated in qmk#15968.

Fixes #34.
0xcharly added a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jan 25, 2023
@0xcharly
Replace EEP_RST with EE_CLR
52eeed2 
`EEP_RST` is deprecated and should be replaced with `EE_CLR`.

Deprecated in qmk#15968.

Fixes #34.
0xcharly added a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jan 27, 2023
@0xcharly
Replace EEP_RST with EE_CLR
9227f74 
`EEP_RST` is deprecated and should be replaced with `EE_CLR`.

Deprecated in qmk#15968.

Fixes #34.
0xcharly added a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jan 27, 2023
@0xcharly
Replace EEP_RST with EE_CLR
c1582b2 
`EEP_RST` is deprecated and should be replaced with `EE_CLR`.

Deprecated in qmk#15968.

Fixes #34.
0xcharly added a commit to Bastardkb/bastardkb-qmk that referenced this pull request Feb 19, 2023
@0xcharly
Replace EEP_RST with EE_CLR
1337125 
`EEP_RST` is deprecated and should be replaced with `EE_CLR`.

Deprecated in qmk#15968.

Fixes #34.
0xcharly added a commit to Bastardkb/bastardkb-qmk that referenced this pull request Feb 28, 2023
@0xcharly
Replace EEP_RST with EE_CLR
e87aa5c 
`EEP_RST` is deprecated and should be replaced with `EE_CLR`.

Deprecated in qmk#15968.

Fixes #34.
salvavic added a commit to salvavic/qmk_corne_salvavic that referenced this pull request Mar 2, 2023
@salvavic
Actualizados codigos a qmk/qmk_firmware#15968
5e6dc11
0xcharly added a commit to Bastardkb/bastardkb-qmk that referenced this pull request Mar 23, 2023
@0xcharly
Replace EEP_RST with EE_CLR
4ddb2ef 
`EEP_RST` is deprecated and should be replaced with `EE_CLR`.

Deprecated in qmk#15968.

Fixes #34.
0xcharly added a commit to Bastardkb/bastardkb-qmk that referenced this pull request Mar 28, 2023
@0xcharly
Replace EEP_RST with EE_CLR
32decf9 
`EEP_RST` is deprecated and should be replaced with `EE_CLR`.

Deprecated in qmk#15968.

Fixes #34.
mattpcaswell pushed a commit to mattpcaswell/qmk_firmware that referenced this pull request Jun 7, 2023
@noroadsleft
Update Legacy Quantum Keycodes (qmk#1127)
2cd1a81 
* Update Keycode List

Per qmk/qmk_firmware Pull Requests qmk#14726 & qmk#15968.

- change `KC_SLCK` to `KC_SCRL`
- change `KC_NLCK` to `KC_NUM`
- change `KC_RO` to `KC_INT1`
- change `KC_KANA` to `KC_INT2`
- change `KC_JYEN` to `KC_INT3`
- change `KC_HENK` to `KC_INT4`
- change `KC_MHEN` to `KC_INT5`
- change `KC_HAEN` to `KC_LNG1`
- change `KC_HANJ` to `KC_LNG2`
- change `RESET` to `QK_BOOT`
- change `DEBUG` to `DB_TOGG`
- change `EEP_RST` to `EE_CLR`
- change `KC_GESC` to `QK_GESC`

* update keymaps to use KC_SCRL

* update keymaps to use KC_NUM

* update keymaps to use KC_INT1

* update keymaps to use KC_INT2

* update keymaps to use KC_INT3

* update keymaps to use KC_INT4

* update keymaps to use KC_INT5

* update keymaps to use KC_LNG1

* update keymaps to use KC_LNG2

* update keymaps to use QK_BOOT, 0-9

* update keymaps to use QK_BOOT, A

* update keymaps to use QK_BOOT, B

* update keymaps to use QK_BOOT, C

* update keymaps to use QK_BOOT, D

* update keymaps to use QK_BOOT, E

* update keymaps to use QK_BOOT, F-G

* update keymaps to use QK_BOOT, H

* update keymaps to use QK_BOOT, I-J

* update keymaps to use QK_BOOT, K

* update keymaps to use QK_BOOT, L

* update keymaps to use QK_BOOT, M

* update keymaps to use QK_BOOT, N-O

* update keymaps to use QK_BOOT, P-Q

* update keymaps to use QK_BOOT, R

* update keymaps to use QK_BOOT, S

* update keymaps to use QK_BOOT, T-V

* update keymaps to use QK_BOOT, W-X

* update keymaps to use QK_BOOT, Y-Z

* update keymaps to use DB_TOGG

* update keymaps to use EE_CLR

* update keymaps to use QK_GESC, 0-9 & A-D

* update keymaps to use QK_GESC, E-J

* update keymaps to use QK_GESC, K-L

* update keymaps to use QK_GESC, M-P

* update keymaps to use QK_GESC, R-Z

* update keycode list in keyboard tester
pylbrecht pushed a commit to pylbrecht/qmk_firmware that referenced this pull request Feb 11, 2024
@0xcharly @pylbrecht
Replace EEP_RST with EE_CLR
feaf14d 
`EEP_RST` is deprecated and should be replaced with `EE_CLR`.

Deprecated in qmk#15968.

Fixes qmk#34.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fauxpark @drashna @zvecr