Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tap-hold per key callback invocations. #16058

Closed
wants to merge 1 commit into from

Conversation

mute---
Copy link

@mute--- mute--- commented Jan 26, 2022

Description

Fixed per key functions invocation during tap processing. The issue was in record argument of those invocations. Current event was passed instead of tapping_key event so you could not make tap-hold decision as stated in the docs.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 26, 2022
@drashna drashna requested a review from a team January 26, 2022 18:35
@precondition
Copy link
Contributor

I already opened a PR on that subject #15938

@drashna
Copy link
Member

drashna commented Jan 26, 2022

Duplicate of #15938

@drashna drashna marked this as a duplicate of #15938 Jan 26, 2022
@mute---
Copy link
Author

mute--- commented Jan 26, 2022

Ugh... Not to so far in the past. My bad. Still not merged though

@mute--- mute--- closed this Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants