Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with Python Tests #16162

Merged
merged 4 commits into from Feb 2, 2022
Merged

Fix issues with Python Tests #16162

merged 4 commits into from Feb 2, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Feb 1, 2022

Description

  • Reformat python due to yapf changes
  • Fix pytest keymap list test due to moved nui_mini

Types of Changes

  • Core
  • Bugfix

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team February 1, 2022 16:16
@github-actions github-actions bot added cli qmk cli command python labels Feb 1, 2022
@peepeetee
Copy link
Contributor

image

What I'm getting at from the name of this test, as well as what other tests below it is doing, is that this test tests for a keyboard that's not in a folder. therefore I believe the way to solve this is to find another keyboard that is unlikely to be moved into a folder(my candidate is crkbd) and substitute that

@drashna
Copy link
Member Author

drashna commented Feb 1, 2022

If anything, handwired/onekey would be a better solution, in that case.

@zvecr
Copy link
Member

zvecr commented Feb 1, 2022

If anything, handwired/onekey would be a better solution, in that case.

that would still fall into the "in a folder category" and be covered by the test_list_keymaps_vendor_kb case

@fauxpark
Copy link
Member

fauxpark commented Feb 1, 2022

bfake perhaps?

@peepeetee
Copy link
Contributor

bfake perhaps?

I'm trying to find out exactly which bfake our bfake is, and rename it/put it in a vendor forder accordingly

@tzarc
Copy link
Member

tzarc commented Feb 2, 2022

contra? Mainly to go with the mystique of the legendary reddit post.

@tzarc tzarc merged commit d4dc743 into qmk:develop Feb 2, 2022
@drashna drashna deleted the fix/pytest branch February 2, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants