Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

develop changelog generator: skip code formatting in listing #16215

Merged
merged 1 commit into from
Feb 4, 2022
Merged

develop changelog generator: skip code formatting in listing #16215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/python/qmk/cli/generate/develop_pr_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@
clean1_expr = re.compile(r'\[(develop|keyboard|keymap|core|cli|bug|docs|feature)\]', flags=re.IGNORECASE)
clean2_expr = re.compile(r'^(develop|keyboard|keymap|core|cli|bug|docs|feature):', flags=re.IGNORECASE)

ignored_titles = ["Format code according to conventions"]


def _is_ignored(title):
for ignore in ignored_titles:
if ignore in title:
return


def _get_pr_info(cache, gh, pr_num):
pull = cache.get(f'pull:{pr_num}')
Expand Down Expand Up @@ -81,7 +89,9 @@ def fix_or_normal(info, fixes_collection, normal_collection):
else:
normal_collection.append(info)

if "dependencies" in commit_info['pr_labels']:
if _is_ignored(commit_info['title']):
return
elif "dependencies" in commit_info['pr_labels']:
fix_or_normal(commit_info, pr_list_bugs, pr_list_dependencies)
elif "core" in commit_info['pr_labels']:
fix_or_normal(commit_info, pr_list_bugs, pr_list_core)
Expand Down