Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Wait time to sending each Keys for Dynamic Macros function #16800

Merged
merged 5 commits into from Jul 2, 2022

Conversation

FREEWING-JP
Copy link

Description

When recording and playing back UI operations in the Dynamic Macros function, the UI may miss keystrokes because the keys are sent too fast.
This problem can be solved by adding a wait time for each key transmission.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most items in this area are _DELAY and not "wait".

docs/feature_dynamic_macros.md Outdated Show resolved Hide resolved
quantum/process_keycode/process_dynamic_macro.c Outdated Show resolved Hide resolved
docs/ja/feature_dynamic_macros.md Outdated Show resolved Hide resolved
FREEWING-JP and others added 3 commits April 6, 2022 09:54
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
@FREEWING-JP FREEWING-JP requested a review from zvecr April 6, 2022 00:54
@zvecr zvecr changed the base branch from master to develop April 6, 2022 14:45
@zvecr zvecr requested a review from a team April 6, 2022 20:47
@drashna
Copy link
Member

drashna commented Apr 6, 2022

It may be worth having this set to use TAP_CODE_DELAY by default, or just use it altogether, rather than a separate define.

@FREEWING-JP
Copy link
Author

I traced program .
dynamic_macro_play() -> process_record() -> process_record_handler() -> process_action() .
In process_action() function using TAP_CODE_DELAY .

Looks like It is not appropriate to put delay logic inside the dynamic_macro_play() function .
However, defining TAP_CODE_DELAY affects all process_record()/ process_actions() .

Hmm...

@tzarc tzarc merged commit 9dc7b9d into qmk:develop Jul 2, 2022
@FREEWING-JP
Copy link
Author

Thank you .

@FREEWING-JP FREEWING-JP deleted the feature/add_dynamic_macro_wait branch July 4, 2022 15:13
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants