Fix kinetic mouse mode #16950
Closed
Fix kinetic mouse mode #16950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kinetic mouse mode is currently broken, as described in #12082 and #13711. The PR #11766 introduced a set of fixes in early 2021. This PR was closed in favour of ongoing refactoring of QMK's mouse code (see #11766 (comment) and #12082 (comment)). Since the mentioned comments, it appears nothing has been merged in order to fix kinetic mode, meaning kinetic mode is still broken. This commit adopts the changes from the pull request that was originally supposed to fix the problem, and updates the changes to handle recent changes to the mousekey.c file. These changes have been tested with my personal keyboard, and result in kinetic mode working as advertised. Co-Authored-By: Jan Christoph Ebersbach <jceb@e-jc.de>
|
I noticed the documentation states to not use |
|
Yes to both. This should target the develop branch, as it is definitely a behavior change, and we recommend not working from your master branch as it may make things more difficult when updating your fork. |
|
@drashna In this case the fork is set up specifically for these changes, my own fork lives elsewhere. Either way, I'll see if I can change the source branch 😃 |
|
It seems I have to recreate the pull request with the new source branch, so I'll do that. |
|
New pull request is here: #16951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kinetic mouse mode is currently broken, as described in #12082 and #13711.
The PR #11766 introduced a set of fixes in early 2021. This PR was closed in favour of ongoing refactoring of QMK's mouse code (see #11766 (comment) and #12082 (comment)).
Since the mentioned comments, it appears nothing has been merged in order to fix kinetic mode, meaning kinetic mode is still broken. This commit adopts the changes from the pull request that was originally supposed to fix the problem, and updates the changes to handle recent changes to the mousekey.c file.
These changes have been tested with my personal keyboard, and result in kinetic mode working as advertised.
Types of Changes
Issues Fixed or Closed by This PR
Fixes #12082
Fixes #13711
Checklist