Add new function for encode module #16954

KeychronMacro · 2022-04-28T09:31:39Z

Improved encoder

Description

Improve the encoder and make it perform better, specifcally add a function called "encoder_insert_state", and will be called in pal set line event callback function when we turn the knob every time.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Fixed encoder and update q2

zvecr · 2022-04-28T15:21:26Z

Core changes should be separate to keyboard changes.

lokher · 2022-04-29T01:06:56Z

Core changes should be separate to keyboard changes.

We added a new function to encoder.h and encoder.c, which is only invoked by Q2, and it won't break anything, why do we need to separate it? It's kinda wierd if we just add a single function, maybe someone would ask how to use it to fix this issue.

zvecr · 2022-04-29T01:19:51Z

Because that is the process we ask people to follow, as it allows us manage the project easier.

By default core changes also have to go via develop, so i have updated the merge target (this is within the PR checklist).

FWest98 · 2022-06-05T23:19:34Z

This change no longer works properly - it causes the rotary encoder to stop functioning altogether. This is due to the new if-condition at https://github.com/qmk/qmk_firmware/blob/master/quantum/encoder.c#L197, introduced in #16068. It prevents the encoder from triggering an action when this code path does not detect a state change - this will almost always be the case since encoder_insert_state already updates this state. The best solution I found to this issue is to introduce an additional condition that will trigger the update function to be called after the external update. See: FWest98@95fbce9#diff-c8e0671af976b0c896b651211e9605562985027873e5ef0d8a51a74c17aa8a6e

github-actions · 2022-08-29T01:16:46Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions · 2022-10-18T02:17:38Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

spacecakes · 2022-11-16T10:58:27Z

Any updates on this? Is it still relevant? @lokher

quantum/encoder.c

drashna · 2022-11-20T05:35:30Z

keyboards/keychron/q2/rev_0111/rules.mk

@@ -20,7 +20,8 @@ ENCODER_ENABLE = yes        # Enable Encoder
 DIP_SWITCH_ENABLE = yes
 RGB_MATRIX_ENABLE = yes
 RGB_MATRIX_DRIVER = CKLED2001
-EEPROM_DRIVER = i2c
+# EEPROM_DRIVER = i2c


Why this change?

This would remove any eeprom support from the board and make via support useless.

github-actions · 2023-01-06T02:03:06Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

tzarc · 2023-01-06T02:48:16Z

quantum/encoder.c

@@ -40,6 +40,7 @@ extern volatile bool isLeftHand;

 static pin_t encoders_pad_a[NUM_ENCODERS_MAX_PER_SIDE] = ENCODERS_PAD_A;
 static pin_t encoders_pad_b[NUM_ENCODERS_MAX_PER_SIDE] = ENCODERS_PAD_B;
+static bool  encoder_external_update[NUM_ENCODERS]     = {false};


This is set-only and never consulted.
As far as I can tell the issue raised by @FWest98 has not been addressed as a result, suggest revisiting this before it goes stale again.

github-actions · 2023-02-21T02:04:44Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

tzarc · 2023-02-21T02:42:11Z

We'll be moving towards a decoupled model with ENCODER_DRIVER = xxxx instead of continuing here.

Update q2

d3f74a3

Fixed encoder and update q2

github-actions bot added core keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 28, 2022

zvecr changed the base branch from master to develop April 29, 2022 01:20

Merge branch 'qmk:master' into fix_encoder

286c4bd

This was referenced Apr 30, 2022

[Feature Request] Add Keychron Q3 #16812

Closed

Keychron q3 #16912

Merged

FWest98 mentioned this pull request Jun 6, 2022

Improve ENCODER_DEFAULT_POS to recognize lost ticks #16932

Merged

14 tasks

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 29, 2022

drashna requested a review from a team September 1, 2022 03:17

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Sep 2, 2022

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 18, 2022

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Nov 17, 2022

drashna requested changes Nov 20, 2022

View reviewed changes

drashna requested a review from a team November 20, 2022 05:35

galican added 2 commits November 21, 2022 11:12

Make q2 lastest allways

cf46e0e

Update q2 to keep trace with upstream/develop

8d41c7c

github-actions bot removed via Adds via keymap and/or updates keyboard for via support keyboard keymap labels Nov 21, 2022

Add new feature

2a5161e

KeychronMacro changed the title ~~Fix Keychron Q2 rotary encoder detection issue~~ Add new function for encode update Nov 21, 2022

KeychronMacro changed the title ~~Add new function for encode update~~ Add new function for encode module Nov 21, 2022

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jan 6, 2023

tzarc reviewed Jan 6, 2023

View reviewed changes

tzarc removed the stale Issues or pull requests that have become inactive without resolution. label Jan 6, 2023

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Feb 21, 2023

tzarc closed this Feb 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new function for encode module #16954

Add new function for encode module #16954

KeychronMacro commented Apr 28, 2022 •

edited

zvecr commented Apr 28, 2022

lokher commented Apr 29, 2022

zvecr commented Apr 29, 2022

FWest98 commented Jun 5, 2022 •

edited

github-actions bot commented Aug 29, 2022

github-actions bot commented Oct 18, 2022

spacecakes commented Nov 16, 2022

drashna Nov 20, 2022

github-actions bot commented Jan 6, 2023

tzarc Jan 6, 2023

github-actions bot commented Feb 21, 2023

tzarc commented Feb 21, 2023

Add new function for encode module #16954

Add new function for encode module #16954

Conversation

KeychronMacro commented Apr 28, 2022 • edited

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

zvecr commented Apr 28, 2022

lokher commented Apr 29, 2022

zvecr commented Apr 29, 2022

FWest98 commented Jun 5, 2022 • edited

github-actions bot commented Aug 29, 2022

github-actions bot commented Oct 18, 2022

spacecakes commented Nov 16, 2022

drashna Nov 20, 2022

Choose a reason for hiding this comment

github-actions bot commented Jan 6, 2023

tzarc Jan 6, 2023

Choose a reason for hiding this comment

github-actions bot commented Feb 21, 2023

tzarc commented Feb 21, 2023

KeychronMacro commented Apr 28, 2022 •

edited

FWest98 commented Jun 5, 2022 •

edited