[Core] Rework PS/2 driver selection #17892
Conversation
Enabling and selecting PS/2 driver was using old approach, so it was reworked to current approach, inspired by Serial and WS2812 driver selections.
gamelaster
changed the title
There was a problem hiding this comment.
@gamelaster Thanks for your PR! I finally had the time to take a better look and these changes look good to me.
|
One thing I would like you to add to this PR is the addition of the PS/2 driver selection to the data driven config mappings in https://github.com/qmk/qmk_firmware/blob/develop/data/mappings/info_rules.json#L33-L34 just like it has been done for the steno protocols. Thank you. |
|
Hi @KarlK90 , I fixed one indentation mistake, and implemented PS2 driver selection to data driver config mappings as you suggested. Please, let me know if it looks good. Thanks 😊 |
Co-authored-by: Drashna Jaelre <drashna@live.com>
|
@gamelaster Great job, works like a charm. While playing around with the changes I recognized that we should probably add the clock and data pins to the data driven mappings as well, so for a "simple" setup we don't need to touch |
|
@gamelaster merged! Thanks for adding the pins. |
* [Core] Rework PS/2 driver selection Enabling and selecting PS/2 driver was using old approach, so it was reworked to current approach, inspired by Serial and WS2812 driver selections. * [Keyboard] Update keyboards using PS/2 to use new PS/2 driver selection * [Docs] Update PS/2 documentation to use new PS/2 driver selection * Fix indentation * [Core] Add PS2 to data driver * Fix oversight in property name Co-authored-by: Drashna Jaelre <drashna@live.com> * Add PS/2 pins to data driven mappings Co-authored-by: Drashna Jaelre <drashna@live.com>
Description
PS/2 driver selection in
common_features.mkwas using old approach (PS2_USE_INT,PS2_USE_BUSYWAITetc.).This PR reworks this to use same approach as Serial or WS2812 drivers, so it also supports vendor drivers.
This PR is first stage of merging my PS/2 driver for RP2040, which uses PIO. The second PR will contain the driver itself, but requires this PR to work.
Types of Changes
Checklist