[Core] Allow custom timings for WS2812 PIO driver #18006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarlK90
force-pushed
the
fix/rp2040-ws2812-pio-timings
branch
2 times, most recently
from
7205957
to
c80004e
Compare
KarlK90
force-pushed
the
fix/rp2040-ws2812-pio-timings
branch
from
c80004e
to
488310c
Compare
jepler
approved these changes
Aug 12, 2022
There was a problem hiding this comment.
I didn't test with this, as I don't have any RP2040 boards on hand while travelling, but it makes perfectly good sense and looks very compile-time flexible. One other "huh I'm surprised qmk_firmware doesn't...." note below, but it doesn't affect adopting this change.
jepler
reviewed
Aug 12, 2022
KarlK90
force-pushed
the
fix/rp2040-ws2812-pio-timings
branch
2 times, most recently
from
cc86b14
to
4c00b6a
Compare
|
Yay ARRAY_SIZE |
KarlK90
force-pushed
the
fix/rp2040-ws2812-pio-timings
branch
2 times, most recently
from
13846fe
to
e526c9b
Compare
|
@sigprof If you happen to have some spare time I would like your opinion on this implementation 🙂 |
KarlK90
force-pushed
the
fix/rp2040-ws2812-pio-timings
branch
from
e526c9b
to
d2d17d3
Compare
KarlK90
force-pushed
the
fix/rp2040-ws2812-pio-timings
branch
from
d2d17d3
to
bb4836c
Compare
|
Tested and running stable since ~2 months on my RP2040 keyboard |
tzarc
approved these changes
Nov 9, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
elpekenin
pushed a commit
to elpekenin/qmk_firmware
that referenced
this pull request
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows setting of custom WS2812 timings using the defines found in
ws2812.h, it also uses these timings as it's default now. Furthermore the reset timing is now applied correctly before starting a new transfer. Due to implementation details the waiting times are rounded to 50ns intervals.WS2812 default timings
T1H + T1LT0H + T0LResetSK6812 timings
T1H + T1LT0H + T0LResetDeviation from 80us due to the driver choosing the longer
T0H + T0LorT1H + T1Lperiod which is irregular in this case.Types of Changes
Issues Fixed or Closed by This PR
Checklist