ws2812: replace RGBLED_NUM with driver-owned constant to decouple driver from RGBLEDs/RGBMATRIX defines #18036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kriechi
force-pushed
the
ws2812-rgbled-num
branch
from
ff8d190
to
a401d0b
Compare
sigprof
reviewed
Aug 14, 2022
14 tasks
Kriechi
force-pushed
the
ws2812-rgbled-num
branch
from
a401d0b
to
1e115d0
Compare
fauxpark
requested changes
Sep 23, 2022
|
I'm thinking, for consistency, perhaps this define should be named |
Kriechi
force-pushed
the
ws2812-rgbled-num
branch
from
1e115d0
to
0f13342
Compare
|
Thanks - changed to |
Kriechi
force-pushed
the
ws2812-rgbled-num
branch
from
0f13342
to
a5a7397
Compare
fauxpark
approved these changes
Sep 23, 2022
sigprof
requested changes
Sep 23, 2022
Kriechi
force-pushed
the
ws2812-rgbled-num
branch
from
a5a7397
to
e4e4ef7
Compare
sigprof
approved these changes
Sep 23, 2022
tzarc
approved these changes
Oct 20, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
…ver from RGBLEDs/RGBMATRIX defines (qmk#18036)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, using ws2812 driver with RGBMATRIX still requires a RGBLED_NUM constant to be defined - which is not documented. Only DRIVER_LED_TOTAL is mentioned - which is currently not sufficient to compile cleanly.
This PR simply checks which defines are available and then defines a new driver-owned constant for the number of ws2812 LEDs to allocate the necessary data structures with the correct size.
Types of Changes
Issues Fixed or Closed by This PR
Checklist