Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix shell: add required pyserial #18124

Closed
wants to merge 1 commit into from
Closed

nix shell: add required pyserial #18124

wants to merge 1 commit into from

Conversation

evils
Copy link

@evils evils commented Aug 21, 2022

Description

#16584 added pyserial as a required dependency, but the nix environment does not provide it, so i can't build firmware
this adds pyserial to the nix environment to fix that

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

i'm not sure if there's a dedicated maintainer of the nix stuff to ping...
but thanks for providing a nix environment :)

@github-actions github-actions bot added the core label Aug 21, 2022
@zvecr zvecr requested a review from sigprof August 21, 2022 17:51
@sigprof
Copy link
Contributor

sigprof commented Aug 21, 2022

I actually prepared a much more extensive update in #18131 (it also updates QMK CLI to 1.1.1, which has the qmk-dotty-dictdotty-dict change, which then requires further updates and Darwin-specific workarounds; all other Python packages also get updated to their current releases to match the typical result of QMK setup on other systems).

@evils
Copy link
Author

evils commented Aug 22, 2022

closing in favour of #18131

@evils evils closed this Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants