Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further refactoring of joystick feature #18437

Merged
merged 9 commits into from
Sep 27, 2022

Conversation

fauxpark
Copy link
Member

Description

Moving almost everything out of process_keycode/; process_joystick.c now solely handles the joystick buttons, though now it's able to be later expanded to add keycodes for axes too, as discussed in #13344. To this end I've chopped up process_joystick_analogread_quantum() into:

int16_t joystick_read_axis(uint8_t axis);
void joystick_read_axes(void);
void joystick_set_axis(uint8_t axis, int16_t value);

Docs have been updated to demonstrate use -- the existing example doesn't appear to actually do anything.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark marked this pull request as ready for review September 23, 2022 14:25
@fauxpark
Copy link
Member Author

All the ARM onekeys are failing on the joystick keymap, since they don't have ADC stuff setup. Everything else appears to be working, though.

@drashna drashna requested a review from a team September 24, 2022 16:16
@fauxpark fauxpark merged commit be8907d into qmk:develop Sep 27, 2022
@fauxpark fauxpark deleted the joystick-refactor branch September 27, 2022 08:37
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants