Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyboards/anavi: Add ANAVI Knob 1 #18623

Merged
merged 1 commit into from Nov 15, 2022
Merged

keyboards/anavi: Add ANAVI Knob 1 #18623

merged 1 commit into from Nov 15, 2022

Conversation

leon-anavi
Copy link
Contributor

ANAVI Knob 1 is a mini mechanical keyboard with a clickable rotary encoder, USB-C, RP2040 microcontroller and I2C slot for a display.

Signed-off-by: Leon Anavi leon.anavi@konsulko.com

Description

Add a new small mechanical keyboard with RP2040. ANAVI Knob 1 is a mini mechanical keyboard with a clickable rotary encoder, USB-C, RP2040 microcontroller and I2C slot for a display.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Oct 7, 2022
View reviewed changes
keyboards/anavi/knob1/glcdfont.c Outdated Show resolved Hide resolved
keyboards/anavi/knob1/config.h Outdated Show resolved Hide resolved
keyboards/anavi/knob1/info.json Outdated Show resolved Hide resolved
keyboards/anavi/knob1/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/anavi/knob1/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/anavi/knob1/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/anavi/knob1/mcuconf.h Show resolved Hide resolved
@leon-anavi leon-anavi force-pushed the anavi-knob-1 branch 2 times, most recently from 13ba5f1 to f47950f Compare October 10, 2022 08:14
drashna
drashna requested changes Oct 14, 2022
View reviewed changes
keyboards/anavi/knob1/knob1.c Show resolved Hide resolved
keyboards/anavi/knob1/knob1.c Outdated Show resolved Hide resolved
@leon-anavi
keyboards/anavi: Add ANAVI Knob 1
5e61aeb 
ANAVI Knob 1 is a mini mechanical keyboard with a clickable rotary
encoder, USB-C, RP2040 microcontroller and I2C slot for a display.

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
@drashna drashna requested a review from a team October 27, 2022 02:01
@leon-anavi
Copy link
Contributor Author

Hi @drashna,

Sorry for bothering you. I am sure you are quite busy but I am wondering is there anything else to be modified in this pull request to get it merged?

I am on hold with changes #18624 because both are quite similar and I want to get this merged first.

Thanks,
Leon

@drashna drashna requested a review from a team November 13, 2022 00:43
@keyboard-magpie keyboard-magpie merged commit 7e843d0 into qmk:master Nov 15, 2022
dkruyt pushed a commit to dkruyt/qmk_firmware that referenced this pull request Nov 18, 2022
@leon-anavi @dkruyt
keyboards/anavi: Add ANAVI Knob 1 (qmk#18623)
9c154e2 
ANAVI Knob 1 is a mini mechanical keyboard with a clickable rotary
encoder, USB-C, RP2040 microcontroller and I2C slot for a display.

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
@leon-anavi @thystips
keyboards/anavi: Add ANAVI Knob 1 (qmk#18623)
435f813 
ANAVI Knob 1 is a mini mechanical keyboard with a clickable rotary
encoder, USB-C, RP2040 microcontroller and I2C slot for a display.

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@leon-anavi @ramonimbao
keyboards/anavi: Add ANAVI Knob 1 (qmk#18623)
6bb015e 
ANAVI Knob 1 is a mini mechanical keyboard with a clickable rotary
encoder, USB-C, RP2040 microcontroller and I2C slot for a display.

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@leon-anavi @elpekenin
keyboards/anavi: Add ANAVI Knob 1 (qmk#18623)
4f4fce0 
ANAVI Knob 1 is a mini mechanical keyboard with a clickable rotary
encoder, USB-C, RP2040 microcontroller and I2C slot for a display.

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@leon-anavi @crembz
keyboards/anavi: Add ANAVI Knob 1 (qmk#18623)
cacff18 
ANAVI Knob 1 is a mini mechanical keyboard with a clickable rotary
encoder, USB-C, RP2040 microcontroller and I2C slot for a display.

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@leon-anavi @nolanseaton
keyboards/anavi: Add ANAVI Knob 1 (qmk#18623)
0228257 
ANAVI Knob 1 is a mini mechanical keyboard with a clickable rotary
encoder, USB-C, RP2040 microcontroller and I2C slot for a display.

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leon-anavi @drashna @fauxpark @keyboard-magpie