AnnePro2: Adjust RGB flushing #18640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI build errors seem to be unrelated to the PR scope. |
tzarc
approved these changes
Oct 8, 2022
|
Works fine on mine. |
zvecr
approved these changes
Oct 8, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
|
@Jpe230 with these changes there is a noticeable latency when I type on my C18 keyboard with animated LED profile enabled. Typed keys are registered slower than usual. |
kdarkhan
added a commit
to kdarkhan/qmk_firmware
that referenced
this pull request
Jan 24, 2023
The current value `RGB_MATRIX_LED_FLUSH_LIMIT 16` causes noticeable input latency when animated RGB profiles are activated. The latency goes away as soon as the RGB is switched off. This issue was introduced after refactoring in qmk#18640 Maybe a proper fix will be refactoring the logic and adjusting the frequency of UART communication. This is a quick fix to make the keyboard usable with RGB enabled.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the flushing of the RGB Matrix from the matrix scan to the flush driver function.
From my tests: the flickering is reduced, and the animations are more fluid.
Types of Changes
Issues Fixed or Closed by This PR
Checklist