Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snowe's KC_RESET to use QK_BOOT #18667

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

precondition
Copy link
Contributor

@precondition precondition commented Oct 10, 2022

Description

Update @snowe2010's crkbd keymap to use QK_BOOT instead of RESET.

PS: I'm not sure if editing user keymaps like that is really accepted but this PR is not too different from #18560 so I think it's ok

commit 19db27a3dbfd91091be06b77bbf5accde380fb31 (HEAD -> update_snowe_s_KC_RESET, origin/update_snowe_s_KC_RESET)
Author: precondition <57645186+precondition@users.noreply.github.com>
Date:   Mon Oct 10 21:12:58 2022 +0200

    Update snowe's KC_RESET to use QK_BOOT

diff --git a/keyboards/crkbd/keymaps/snowe/keycode_aliases.h b/keyboards/crkbd/keymaps/snowe/keycode_aliases.h
index bd70a79aa5..c19fb11d4b 100644
--- a/keyboards/crkbd/keymaps/snowe/keycode_aliases.h
+++ b/keyboards/crkbd/keymaps/snowe/keycode_aliases.h
@@ -42,7 +42,7 @@
 #define COLEMAK KC_COLEMAK
 #define WORKMAN KC_WORKMAN
 
-#define KC_RESET RESET
+#define KC_RESET QK_BOOT
 #define KC_RST KC_RESET
 
 #ifdef SWAP_HANDS_ENABLE
diff --git a/users/snowe/wrappers.h b/users/snowe/wrappers.h
index 9ef7dce607..47fe4a5ace 100644
--- a/users/snowe/wrappers.h
+++ b/users/snowe/wrappers.h
@@ -88,5 +88,5 @@ NOTE: These are all the same length.  If you do a search/replace
 #define _________________ADJUST_L2_________________        MU_TOG , TG(_GAMING), AU_ON,   AU_OFF,  AG_NORM
 #define _________________ADJUST_L3_________________        RGB_RMOD,RGB_HUD,RGB_SAD, RGB_VAD, _______
 #define _________________ADJUST_R1_________________        _______, _______, _______, _______, _______
-#define _________________ADJUST_R2_________________        RESET,   CG_TOGG, _______, _______, _______
+#define _________________ADJUST_R2_________________        KC_RESET,CG_TOGG, _______, _______, _______
 #define _________________ADJUST_R3_________________        _______, KC_MNXT, KC_VOLU, KC_VOLD, KC_MPLY

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Compilation errors when compiling crkbd:snowe

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@keyboard-magpie
Copy link
Contributor

I think this keymap needs overhauling in other areas (OLED code) for it to be contemporary?

@precondition
Copy link
Contributor Author

I think this keymap needs overhauling in other areas (OLED code) for it to be contemporary?

To be fair, I just wanted to fix only the compilation errors so that the CI run for #15741 doesn't fail due to snowe's keymap. So I didn't look further than the error log to check if other areas of the code could use an overhaul.

@fauxpark fauxpark merged commit 17ada03 into qmk:develop Oct 10, 2022
@precondition precondition deleted the update_snowe_s_KC_RESET branch October 11, 2022 08:10
@snowe2010
Copy link
Contributor

@precondition thank you very much! I don't update my code very often so I very much do appreciate any help 😬.

@keyboard-magpie what do I need to fix in the OLED code? A lot of it was very custom and qmk moves very fast and at the rate I update stuff (once a year lol) I get very out of date.

@keyboard-magpie
Copy link
Contributor

precondition thank you very much! I don't update my code very often so I very much do appreciate any help 😬.

keyboard-magpie what do I need to fix in the OLED code? A lot of it was very custom and qmk moves very fast and at the rate I update stuff (once a year lol) I get very out of date.

I think it's as simple as adding # define OLED_TIMEOUT 30000 to config.h- the issues that get reported on the discord server (your keymap is quite popular!) are that the OLED flickers after initial timeout.

@snowe2010
Copy link
Contributor

I think it's as simple as adding # define OLED_TIMEOUT 30000 to config.h- the issues that get reported on the discord server (your keymap is quite popular!) are that the OLED flickers after initial timeout.

haha is it really? man I thought it wasn't very popular judging by the limited number of responses on my reddit post 😅 . I would have kept expanding it if I knew it was popular! I haven't visited the discord in a long time lol. maybe I should go search my username on there 😫

I've wondered how to fix that flicker for a long time! I'm glad the fix is so simple! I'll do that right away. Thank you!

ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants