Add unit tests for HOLD_ON_OTHER_KEY_PRESS #18721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Build error is unrelated and has already been fixed by #18704 |
drashna
approved these changes
Oct 21, 2022
zvecr
approved these changes
Oct 22, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
* Add HOLD_ON_OTHER_KEY_PRESS to data/ files * Add unit tests for HOLD_ON_OTHER_KEY_PRESS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add HOLD_ON_OTHER_KEY_PRESS[_PER_KEY] to data-driven files and create a suite of unit tests to verify the behaviour of modtaps, layertaps and regular keys with HOLD_ON_OTHER_KEY_PRESS.
These commits were originally a part of #15741 but that's a breaking change that will take a long time to get merged. The unit tests for HOLD_ON_OTHER_KEY_PRESS aren't particularly tied to the scope and intent of the “make-ignore-mod-tap-interrupt-the-default” PR so they can be reviewed and merged separately.
Types of Changes
Issues Fixed or Closed by This PR
Checklist