Formalise keyboard- and user-specific EEPROM blocks #18874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzarc
force-pushed
the
dynamic_keymap_start_override
branch
from
7fd4c6d
to
61fbe0b
Compare
|
This feels like it's redundant/reproducing the existing kb/user block: qmk_firmware/quantum/eeconfig.h Lines 41 to 42 in 8456978 Probably should see about merging these, at some point? |
These are repurposed when using the data blocks to check validity. At the moment we're storing a version that can be overridden -- if the firmware format of the data segment changes it can be detected in this way. |
tzarc
force-pushed
the
dynamic_keymap_start_override
branch
4 times, most recently
from
c894b0f
to
76aaa96
Compare
zvecr
approved these changes
Nov 1, 2022
zvecr
reviewed
Nov 1, 2022
tzarc
force-pushed
the
dynamic_keymap_start_override
branch
from
a53e5e1
to
109052d
Compare
14 tasks
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
* Formalise keyboard and user eeconfig datablocks. * Add debounce helper that checks a condition and issues post-write function invocation. * Naming.
elpekenin
pushed a commit
to elpekenin/qmk_firmware
that referenced
this pull request
Dec 7, 2022
* Formalise keyboard and user eeconfig datablocks. * Add debounce helper that checks a condition and issues post-write function invocation. * Naming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two defines,
EECONFIG_KB_DATA_SIZEandEECONFIG_USER_DATA_SIZEwhich "allocate" areas of EEPROM specifically for keyboard and user usage.Skipped docs, as it's envisaged this will be automatically leveraged by XAP later.
Types of Changes
Checklist