Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new boards for Keychron Q1 #19307
Add new boards for Keychron Q1 #19307
Changes from 11 commits
d82082d
6f586f6
9125133
ed92916
b9d87fd
298ac9e
2f780e5
15b050e
84f0d7e
15584d9
a488951
56eec88
5120421
0ea5e40
a36f626
0a90097
01833e3
0de39ca
e545605
32b5529
9e8b310
508b7c4
57db71b
8a2443f
1484a0e
adf6129
9791d12
2d66172
fb6cbf7
27c8a9f
019e0eb
c4b4a96
0cee0e7
32f08f1
ae08e21
6ef5a54
64b9c2d
80e2fe4
60f4b4e
fab84c5
22d9b96
30e82cd
2d4d348
b24bdb2
79aa140
dfefab9
2e7ba65
1f687ad
7fbfae5
561b59a
4639793
850112f
42856b8
1008d68
8cffbec
78e071e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these should be moved to the info.json file.
Also, the NO_PIN's should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, It failed to compile when i removed the NO_PINs from matrix_pins definiton😂.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compile information to remind me that: keychron/q1/ansi_stm32l432: led_config: ansi_stm32l432.c: Number of columns in row 0 (16) does not match matrix (8) and that: keychron/q1/ansi_stm32l432: led_config: ansi_stm32l432.c: Number of columns in row 0 (16) does not match matrix (8)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a higher level that has MATRIX_COLS and MATRIX_ROWS defined? If so, that would be why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This board uses a custom matrix; pins declared as
NO_PIN
are actually connected to a shift register. The code is mostly the same as for other similar Keychron boards already in the repo (q10, q12, q3, q5, q6, q65, v1, v10, v3, v5, v6).