Adds Planck Rev 7 #21156
Adds Planck Rev 7 #21156
Conversation
keyboards/planck/rev7/matrix.c
Outdated
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| #include "config.h" |
There was a problem hiding this comment.
shouldn't need. And should be converted to matrix lite.
| #include "config.h" |
There was a problem hiding this comment.
I can convert this & rev6_drop's matrix to lite separately.
There was a problem hiding this comment.
I can convert this & rev6_drop's matrix to lite separately.
"separately" as in not as part of this PR? If so, we would usually block merge on such a decision.
There was a problem hiding this comment.
Separately in another PR, because I don't want to update rev6_drop here and would rather have their implementations match for the time being.
There was a problem hiding this comment.
I agree rev6_drop should not be changed as part of this PR. However the matrix code is not the same, so it being aligned is already false. Its called out in the PR checklist, and has been requested/required on many previous PRs.
There was a problem hiding this comment.
It should be the same matrix code aside from the encoder matrix additions.
There was a problem hiding this comment.
Nope, different, not really close given one is using iteration and GPIO abstraction and the other ChibiOS directly.
Co-authored-by: Drashna Jaelre <drashna@live.com>
|
Closed in favor of #21175 |
Types of Changes
Checklist