[Keyboard] Add Pimoroni Keybow 2040 #21481

fanf2 · 2023-07-08T17:46:13Z

Description

The Pimoroni Keybow 2040 is a 16 key mechanical macropad controlled by a Raspberry Pi RP2040, with Kailh hot swap sockets and per key RGB lighting, in a decorative FR4 sandwich.

I am not associated with Pimoroni, I just own a Keybow 2040. I thought installing QMK on it might be a fun way to learn more about QMK. LITTLE DID I KNOW...

As far as I know, all the problems with this PR have been resolved, so it should be ready to go.

The following struck-out sections describe some problems I had when trying to get it to work. They are retained for historical interest only.

VIA

~~On my M1 Mac, VIA.app is stuck "Searching for devices..."~~

~~I have tried loading keybow2040.json (from thte VIA commit in this PR) into VIA's "Design" tab: still no luck.~~

~~I ttried adding a little debug logging to raw_hid_receive() in quantum/via.c, but it never prints anything to the console.~~

~~I also have a Mechboards / Yiancar HS60 which used to work with VIA, but does not any more.~~

So I currently suspect something is broken with VIA, but it does not seem possible to get any information out of VIA to explain what it is doing and what is or is not working, and searchengineering has so far not helped me find a solution.

LEDs

~~Another frustrating failure, I'm afraid~~

I seem to be suffering from some kind of asynchronous corruption of the global matrix[] array. I tried to track it down with a lot of VERIFY_TRACED_VARIABLES() but I ended up at some code that could not possiblly be blamed, unless the corruption was coming from some kind of interrupt service routine.

Despite that

I have tracked down the relevant source code for the Keybow 2040 default CircuitPython firmware, and together with its published schematic I think most of the configuration setttings are reasonably plausible (tho I have not been able to test things like the orientation of the LED matrix). The readme.md contains links to the more obscure information I used.

Types of Changes

Checklist

My code follows the code style of this project
~~nah, I can fix that when the code work~~
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation
~~maybe, dunno yet if there are things I learned that could go into the docs~~
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work
~~heh lol not quite~~ 😭

keyboards/pimoroni/keybow2040/keybow2040.c

sigprof · 2023-07-08T19:08:59Z

On my M1 Mac, VIA.app is stuck "Searching for devices..."

Are you using the latest VIA.app? Although it seems that the preferred way to use VIA now is to open https://usevia.app in a Chrome-based browser (the required WebHID support is currently not present in any other browser engine). Any old version of the local VIA application won't work with recent firmwares (and new versions are just Electron wrappers for https://usevia.app).

fanf2 · 2023-07-08T19:21:09Z

Yes, I installed VIA 2.2 and 3.0, neither worked.

I prefer to avoid Google as much as possible. I wonder if VIA is failing at rawhid because of Apple security restrictions on an unsigned executable, but who can say without debug logging 🤷 Maybe the Chrome dev tools will be more helpful. Yuck.

keyboards/pimoroni/keybow2040/info.json

keyboards/pimoroni/keybow2040/config.h

keyboards/pimoroni/keybow2040/keybow2040.c

keyboards/pimoroni/keybow2040/keymaps/default/keymap.json

keyboards/pimoroni/keybow2040/keymaps/via/keybow2040.json

keyboards/pimoroni/keybow2040/keymaps/via/keymap.json

keyboards/pimoroni/keybow2040/readme.md

sigprof · 2023-07-08T19:39:26Z

I prefer to avoid Google as much as possible.

On Linux ungoogled-chromium can be used with https://usevia.app; no idea whether it would work on MacOS (especially on the M1 platform).

drashna · 2023-07-08T20:24:45Z

I prefer to avoid Google as much as possible.

On Linux ungoogled-chromium can be used with usevia.app; no idea whether it would work on MacOS (especially on the M1 platform).

For Ventura, I found that I had to explicitly add the via app to the "input monitoring" permissions before via would work. Same with the toolbox for the console/hid bootloaders.

fanf2 · 2023-07-11T17:47:35Z

I have pushed round two of this pull request 🎉

Many thanks to @sigprof for the thorough and helpful review, and thanks to @drashna for the extra hints and tips!

I have gone through the review comments and I think I have addressed them all. My apologies if I missed any.

I got the RGB matrix working after much careful checking of each LED's register number, and the corresponding key and LED locations should match. (I understand now how the incorrect LED register numbers could cause out-of-bounds array accesses which would explain the mysterious memory corruption I was struggling with before.)

There were also some problems with inconsistencies in my I2C driver configuration. I cleaned them up to match the board's schematic: it uses GPIOs 4 and 5 for I2C, and those pins are connected to the RP2040's I2C0 peripheral. However, a perfectly consistent I2C0 configuration does not compile because some of QMK's code assumes that I2C1 is configured. If I add a dummy I2C1 configuration that refers to unused RP2040 pins, the RGB matrix remains black. If I tell the driver to use the same GPIO pins for I2C0 and I2C1, it compiles and works. 🧐

I have not yet tested that VIA works if I use Chrome. Maybe after I have had something to eat.

keyboards/pimoroni/keybow2040/mcuconf.h

keyboards/pimoroni/keybow2040/config.h

keyboards/pimoroni/keybow2040/info.json

keyboards/pimoroni/keybow2040/halconf.h

fanf2 · 2023-07-12T09:10:09Z

Round three!

Thanks again to @sigprof for your helpful guidance. I think I've addressed the problems you found. I have added some improved explanatory comments to keybow2040/config.h; I hope they are correct!

fanf2 · 2023-07-19T15:07:58Z

Hello again,

I gave my Keybow 2040 a prod with VIA running in Chrome instead of the Electron version, and it seemed to work OK.

I think all the problems with this PR have been resolved. Please let me know if there's anything else I can do to help get it merged :-)

mosch · 2023-07-26T19:43:41Z

@fanf2 thanks for working on this! I can confirm the fw works on my Keybow 2040.

Im also having issues with the via app. Tested the downloadable version and usevia.app; on Win+Mac in Chrome + Edge. @fanf2 how did you get it working?

The Keybow shows up in the browser dialog (shows as paired). However I only see the [Authorized Device +] Button.

fanf2 · 2023-07-27T17:40:19Z

Hi, @mosch,

VIA does not yet know about the Keybow 2040; I have been waiting for this PR to be merged before I open the PR for VIA supprt.

Until it gets official support from VIA, you need to make the following incantations:

go to the settings (cogwheel) tab in VIA;
turn on the "show design tab" switch
go to the design (paintbrush) tab;
bop the "load draft definition" button
feed it a copy of the following JSON

{
    "name": "Pimoroni Keybow 2040",
    "vendorId": "0x5069",
    "productId": "0x4784",
    "matrix": {
	"rows": 5,
	"cols": 4
    },
    "layouts": {
	"keymap": [
	    [{"x":2.5,"w":0.5,"h":0.5,"w2":1},"4,0"],
	    [{"y":-0.5},"0,0","0,1","0,2","0,3"],
	    ["1,0","1,1","1,2","1,3"],
	    ["2,0","2,1","2,2","2,3"],
	    ["3,0","3,1","3,2","3,3"]
	]
    }
}

mosch · 2023-07-28T08:26:45Z

Sweet that works, Thank you!

mosch

I think we are missing a comma here. I also found that this JSON uses tailing commas, while the others don't.

keyboards/pimoroni/keybow2040/info.json

mosch · 2023-08-09T06:09:17Z

This looks good now, anything missing before getting it in? @sigprof

keyboards/pimoroni/keybow2040/readme.md

drashna · 2023-08-03T06:33:04Z

keyboards/pimoroni/keybow2040/readme.md

This should follow the default template:
https://raw.githubusercontent.com/qmk/qmk_firmware/master/data/templates/keyboard/readme.md

keyboards/pimoroni/keybow2040/keybow2040.c

keyboards/pimoroni/keybow2040/config.h

itsnelsonmartins

change from IS31FL3731 to is31fl3731 to fix QMK CI Run

keyboards/pimoroni/keybow2040/info.json

fanf2 · 2023-09-03T17:39:01Z

OK, I have updated the readme.md to follow the template more closely. I don't have an imgur account so I deleted the hero image. I have improved keybow2040.c, config.h, and info.json as suggested.

Thank you for the review and style fixes. I hope it is now good to go!

drashna · 2023-09-15T19:07:35Z

keyboards/pimoroni/keybow2040/readme.md

+Keybow 2040
+===========


Suggested change

Keybow 2040

===========

# Keybow 2040

drashna · 2023-09-15T19:10:08Z

keyboards/pimoroni/keybow2040/readme.md

+bootloader
+----------
+
+The procedure to flash the firmware is similar to other RP2040
+devices. You can enter the bootloader in two ways:
+
+  * **Vulcan nerve pinch**: hold down BOOTSEL while pressing RESET
+    (not so great if you have configured BOOTSEL to do something)
+
+  * **Mr Resetti double-tap**: press RESET twice quickly
+    (only works when running the QMK firmware)
+
+Find the BOOTSEL and RESET buttons on your Keybow 2040 either side of
+the USB socket on the edge of the PCB. When the USB socket is facing
+away from you, BOOTSEL is on the right and RESET is on the left.
+According to the schematic the reset button is called Mr Resetti.
+
+  * _Aside_: The BOOTSEL button disables the QSPI flash that stores
+    the firmware, which makes the RP2040 use its built-in UF2
+    bootloader.
+
+A USB drive will appear called `RPI-RP2`. Copy the firmware file
+`pimoroni_keybow2040_default.uf2` onto the `RPI-RP2` drive using
+whatever software is convenient (e.g. the `cp` command, the macOS
+Finder, or Windows Explorer). The `make :flash` command will copy the
+firmware for you.
+
+The `RPI-RP2` drive will disappear (which might make your OS complain
+that you failed to unmount it first) and a keyboard device will appear
+in its place.
+
+The Pimoroni web site has [instructions for reinstalling CircuitPython
+on the Keybow 2040](https://learn.pimoroni.com/article/circuitpython-and-keybow-2040)
+


Suggested change

bootloader

----------

The procedure to flash the firmware is similar to other RP2040

devices. You can enter the bootloader in two ways:

* **Vulcan nerve pinch**: hold down BOOTSEL while pressing RESET

(not so great if you have configured BOOTSEL to do something)

* **Mr Resetti double-tap**: press RESET twice quickly

(only works when running the QMK firmware)

Find the BOOTSEL and RESET buttons on your Keybow 2040 either side of

the USB socket on the edge of the PCB. When the USB socket is facing

away from you, BOOTSEL is on the right and RESET is on the left.

According to the schematic the reset button is called Mr Resetti.

* _Aside_: The BOOTSEL button disables the QSPI flash that stores

the firmware, which makes the RP2040 use its built-in UF2

bootloader.

A USB drive will appear called `RPI-RP2`. Copy the firmware file

`pimoroni_keybow2040_default.uf2` onto the `RPI-RP2` drive using

whatever software is convenient (e.g. the `cp` command, the macOS

Finder, or Windows Explorer). The `make :flash` command will copy the

firmware for you.

The `RPI-RP2` drive will disappear (which might make your OS complain

that you failed to unmount it first) and a keyboard device will appear

in its place.

The Pimoroni web site has [instructions for reinstalling CircuitPython

on the Keybow 2040](https://learn.pimoroni.com/article/circuitpython-and-keybow-2040)

## Bootloader

Enter the bootloader in 3 ways:

* **Bootmagic reset**: Hold down the key at (0,0) in the matrix (usually the top left key or Escape) and plug in the keyboard

* **Physical reset button**: Double tap the RESET button, or hold BOOTSEL and tap RESET

The Pimoroni web site has [instructions for reinstalling CircuitPython

on the Keybow 2040](https://learn.pimoroni.com/article/circuitpython-and-keybow-2040)

This change is wrong, because I have not enabled the bootmagic feature:

there's no point since the reset and bootsel buttons are easily accessible on the side of the Keybow2040

the RP2040's ROM implements the bootsel feature, so there's no need for QMK to do so

the bootsel button is not (0,0) in the matrix because that would mess up the 4x4 layout

I've trimmed the tutorial parts of that section, and added a sentence about bootsel vs bootmagic.

I've left my jokes in because this is supposed to be fun 🤪

Bootmagic doesn't just reset the board and jump to bootloader, it also clears the eeprom. Which can be very useful. And has nothing to do with the bootsel button (it's just an arbitrary spot in the matrix, but defaults to 0,0).

drashna · 2023-09-15T19:10:30Z

keyboards/pimoroni/keybow2040/readme.md

+notes
+-----
+
+  * The BOOTSEL button doubles as a 17th configurable key.
+
+  * The default keymap has F13 - F20 on the top half of the board
+    (nearest the USB socket), and a navigation cluster (arrows, home,
+    end, page up/down) on the bottom half. The BOOTSEL button changes
+    the RGB matrix mode.
+
+  * The Keybow 2040 CircuitPython firmware uses VID = 0x16D0, PID = 0x08C6,
+    but this QMK firmware has different USB IDs to avoid confusing drivers:
+    VID = 0x5069 ('Pi'), PID = 0x4784 (4 'x' 4)
+


Not sure how useful this is here.

Suggested change

notes

-----

* The BOOTSEL button doubles as a 17th configurable key.

* The default keymap has F13 - F20 on the top half of the board

(nearest the USB socket), and a navigation cluster (arrows, home,

end, page up/down) on the bottom half. The BOOTSEL button changes

the RGB matrix mode.

* The Keybow 2040 CircuitPython firmware uses VID = 0x16D0, PID = 0x08C6,

but this QMK firmware has different USB IDs to avoid confusing drivers:

VID = 0x5069 ('Pi'), PID = 0x4784 (4 'x' 4)

I've left that in because there ought to be somewhere for users to find out what the default keymap is without reading the JSON, and I need somewhere to explain the info.json configuration choices. JSON isn't supposed to have comments, so 🤷

drashna · 2023-09-15T19:12:16Z

keyboards/pimoroni/keybow2040/readme.md

+resources
+---------
+
+Here are some links to the information I used when configuring QMK for the Keybow 2040.
+
+  * [Piomoroni Keybow 2040 product page](https://shop.pimoroni.com/products/keybow-2040)
+  * [Keybow 2040 assembly instructions](https://learn.pimoroni.com/article/assembling-keybow-2040)
+
+Places to find information about the Keybow 2040 hardware:
+
+  * [schematic](https://cdn.shopify.com/s/files/1/0174/1800/files/keybow_2040_schematic.pdf)
+      * contains most of the information that can also be gleaned from the CircuitPython support
+
+  * Pimoroni user-friendly CircuitPython libraries
+      * [old](https://github.com/pimoroni/keybow2040-circuitpython) and [new](https://github.com/pimoroni/pmk-circuitpython)
+      * these are wrappers around the low-level support below
+
+  * [CircuitPython hardware support](https://github.com/adafruit/circuitpython/blob/main/ports/raspberrypi/boards/pimoroni_keybow2040/)
+      * defines map from hardware feature names (e.g. `SW15`) to the way they are accessed (e.g. GPIO6)
+
+  * [CircuitPython IS31FL3731 driver](https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731/blob/main/adafruit_is31fl3731/keybow2040.py)
+      * defines the RGB matrix layout


This would be better linked in the "hardware supported" section above. Though, it looks like most of this is linked in the product page, already.

Suggested change

resources

---------

Here are some links to the information I used when configuring QMK for the Keybow 2040.

* [Piomoroni Keybow 2040 product page](https://shop.pimoroni.com/products/keybow-2040)

* [Keybow 2040 assembly instructions](https://learn.pimoroni.com/article/assembling-keybow-2040)

Places to find information about the Keybow 2040 hardware:

* [schematic](https://cdn.shopify.com/s/files/1/0174/1800/files/keybow_2040_schematic.pdf)

* contains most of the information that can also be gleaned from the CircuitPython support

* Pimoroni user-friendly CircuitPython libraries

* [old](https://github.com/pimoroni/keybow2040-circuitpython) and [new](https://github.com/pimoroni/pmk-circuitpython)

* these are wrappers around the low-level support below

* [CircuitPython hardware support](https://github.com/adafruit/circuitpython/blob/main/ports/raspberrypi/boards/pimoroni_keybow2040/)

* defines map from hardware feature names (e.g. `SW15`) to the way they are accessed (e.g. GPIO6)

* [CircuitPython IS31FL3731 driver](https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731/blob/main/adafruit_is31fl3731/keybow2040.py)

* defines the RGB matrix layout

I have left these links in because it was difficult to find the relevant parts of the default Python firmware, so I think it will be helpful when anyone else wants to work on this board.

But this isn't the circuit python repo, so has zero relevance here. And most of the links add no value.

github-actions · 2023-11-03T01:49:43Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

mosch · 2023-11-03T07:33:47Z

How can I help getting this in? I think it's a vaulable contribution and brings a great keyboard into QMK. Let's get this in!

willoucom · 2023-12-10T09:32:16Z

Hello,
I have compiled and tested this firmware and it works perfectly.
Is it possible to review this PR again?
Can I help?
Thank you very much

keyboard-magpie · 2023-12-10T11:55:36Z

@fanf2 will need to accept some of the suggested changes above still.

Additionally, there are some changes required since a round of breaking changes has passed- qmk migrate and/or qmk info -kb pimoroni/keybow2040 -f json may help you find these.

zvecr · 2023-09-09T13:24:37Z

keyboards/pimoroni/keybow2040/rules.mk

@@ -0,0 +1 @@
+# Blankety Blank chequebook and pen


Suggested change

# Blankety Blank chequebook and pen

# This file intentionally left blank

Good grief am I not allowed to express my personality at all?

No, as it makes refactoring at a later date more complicated.

zvecr · 2023-09-09T13:41:30Z

keyboards/pimoroni/keybow2040/mcuconf.h

+/*
+ * see config.h for notes on the Keybow 2040 I2C setup
+ */
+#undef  RP_I2C_USE_I2C0
+#undef  RP_I2C_USE_I2C1
+#define RP_I2C_USE_I2C0 TRUE
+#define RP_I2C_USE_I2C1 FALSE


Suggested change

/*

* see config.h for notes on the Keybow 2040 I2C setup

*/

#undef RP_I2C_USE_I2C0

#undef RP_I2C_USE_I2C1

#define RP_I2C_USE_I2C0 TRUE

#define RP_I2C_USE_I2C1 FALSE

#undef RP_I2C_USE_I2C0

#define RP_I2C_USE_I2C0 TRUE

#undef RP_I2C_USE_I2C1

#define RP_I2C_USE_I2C1 FALSE

Nah, I prefer my version.

You can close this PR then if you like.

zvecr · 2023-09-09T13:44:10Z

keyboards/pimoroni/keybow2040/halconf.h

+/*
+ * see config.h for notes on the Keybow 2040 I2C setup
+ */


Suggested change

/*

* see config.h for notes on the Keybow 2040 I2C setup

*/

I'm not removing this because it's an important cross-reference that I wanted (but lacked) when I was working on this code.

config.h is a standard file in QMK. There is absolutely no need to tell users about it here.

Not sure how adding that adds any value over what is in the docs.
RE: https://docs.qmk.fm/#/i2c_driver?id=arm-configuration

zvecr · 2023-09-09T13:45:11Z

keyboards/pimoroni/keybow2040/keybow2040.c

+/*
+ * see Keybow 2040 schematic for the LED wiring
+ */


Suggested change

/*

* see Keybow 2040 schematic for the LED wiring

*/

I'm not removing this because it's an important cross-reference that I failed to find as soon as I would have liked when I was working on this code.

How so? Or rather, why wouldn't every keyboard need this, then? "see schematic" is useless information, as that's always the goto when referencing the design.

It's like "see readme for details". It's pointless.

zvecr · 2023-12-10T16:58:18Z

keyboards/pimoroni/keybow2040/config.h

+
+#define RGB_MATRIX_LED_COUNT (4 * 4)
+#define RGB_MATRIX_KEYPRESSES
+
+/*
+ * LED driver chip count: one IS31FL3731
+ */
+#define DRIVER_COUNT 1
+


Suggested change

#define RGB_MATRIX_LED_COUNT (4 * 4)

#define RGB_MATRIX_KEYPRESSES

/*

* LED driver chip count: one IS31FL3731

*/

#define DRIVER_COUNT 1

Dunno why this change is needed?

All three of these defines are no longer necessary.

Because they are no longer required.

OK, I guess the DRIVER_COUNT is obsolete since 84df695

And RGB_MATRIX_LED_COUNT is obsolete since 95681b8

And DRIVER_COUNT since 84df695

Dunno what the issue is with RGB_MATRIX_KEYPRESSES?

It's implied when you have at least one reactive effect enabled dfb6d38.

zvecr · 2023-12-10T17:00:39Z

keyboards/pimoroni/keybow2040/config.h

+/*
+ * I2C address: IS31FL3731 AD pin is connected to ground
+ */
+#define DRIVER_ADDR_1 0b1110100
+
+/*
+ * The RP2040 has two I2C peripherals; I2C0 must be used with GPIO 4
+ * and 5 which on the Keybow 2040 are wired up to the IS31FL3731.
+ */
+#define I2C_DRIVER I2CD0
+
+/*
+ * I2C1 here refers to the board's / QMK's first (and only) I2C
+ * peripheral, not to the RP2040's second I2C peripheral.
+ */


Suggested change

/*

* I2C address: IS31FL3731 AD pin is connected to ground

*/

#define DRIVER_ADDR_1 0b1110100

/*

* The RP2040 has two I2C peripherals; I2C0 must be used with GPIO 4

* and 5 which on the Keybow 2040 are wired up to the IS31FL3731.

*/

#define I2C_DRIVER I2CD0

/*

* I2C1 here refers to the board's / QMK's first (and only) I2C

* peripheral, not to the RP2040's second I2C peripheral.

*/

#define IS31FL3731_I2C_ADDRESS_1 IS31FL3731_I2C_ADDRESS_GND

#define I2C_DRIVER I2CD0

Dunno why this change is needed?

ISSI addresses should now use their respective defines instead of literals, for consistency and clarity.

Because things were refactored last develop cycle?

OK, I see #define DRIVER_ADDR_1 needs changing since d56ee70

Other than that, it's wrong to remove the comments since they explain where the values come from.

The docs are a far better place for that kind of explanation, you know...

fanf2 · 2023-12-12T00:24:14Z

OK, I've gone through the comments and worked out where most of the unexplained ones came from, so I think this PR is now up-to-date with the upstream changes in the last three months.

I have reflashed my keybow2040 and it seems to be working ok.

fauxpark · 2023-12-12T00:31:40Z

keyboards/pimoroni/keybow2040/keybow2040.c

+/*
+ * the LED addresses must match the wiring in the Keybow 2040 schematic
+ */
+const is31_led PROGMEM g_is31_leds[RGB_MATRIX_LED_COUNT] = {


Suggested change

const is31_led PROGMEM g_is31_leds[RGB_MATRIX_LED_COUNT] = {

const is31fl3731_led_t PROGMEM g_is31fl3731_leds[IS31FL3731_LED_COUNT] = {

fauxpark · 2023-12-12T00:32:49Z

keyboards/pimoroni/keybow2040/info.json

+            ["GP19", "GP15", "GP11", "GP7"],
+            ["GP20", "GP16", "GP12", "GP8"],
+            ["GP21", "GP17", "GP13", "GP9"],
+            ["GP23", "NO_PIN", "NO_PIN", "NO_PIN"]


Suggested change

["GP23", "NO_PIN", "NO_PIN", "NO_PIN"]

["GP23", null, null, null]

github-actions · 2024-01-27T01:47:18Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions · 2024-02-26T01:48:18Z

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

Gadgetoid · 2024-05-15T15:28:03Z

@fanf2 thank you for all the effort you've put in here.

Could I please implore you to defer to the maintainers and get this PR ship-shaped when you have the time?

I would love to see this PR merged and for us (disclaimer: I'm the software wrangler at Pimoroni) to have a toe into the QMK world.

Thank you! 🎉

github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 8, 2023

sigprof reviewed Jul 8, 2023

View reviewed changes

keyboards/pimoroni/keybow2040/keybow2040.c Outdated Show resolved Hide resolved

sigprof requested changes Jul 8, 2023

View reviewed changes

fanf2 marked this pull request as draft July 8, 2023 20:24

fanf2 force-pushed the pimoroni_keybow_2040 branch 2 times, most recently from 2580a3a to 172954c Compare July 11, 2023 17:19

fanf2 marked this pull request as ready for review July 11, 2023 17:27

sigprof requested changes Jul 11, 2023

View reviewed changes

fanf2 force-pushed the pimoroni_keybow_2040 branch 3 times, most recently from ec6a691 to e228d62 Compare July 12, 2023 09:05

fanf2 force-pushed the pimoroni_keybow_2040 branch 2 times, most recently from e18b055 to d67f5e8 Compare July 12, 2023 09:55

fanf2 force-pushed the pimoroni_keybow_2040 branch from d67f5e8 to 2b9c428 Compare July 19, 2023 14:59

fanf2 force-pushed the pimoroni_keybow_2040 branch from 2b9c428 to 41ecb03 Compare July 25, 2023 11:44

mosch reviewed Jul 28, 2023

View reviewed changes

keyboards/pimoroni/keybow2040/info.json Outdated Show resolved Hide resolved

fanf2 force-pushed the pimoroni_keybow_2040 branch 2 times, most recently from 9f3d63d to 344aa9c Compare July 28, 2023 09:23

fanf2 force-pushed the pimoroni_keybow_2040 branch from 344aa9c to 59c19e8 Compare August 10, 2023 13:36

drashna requested changes Aug 14, 2023

View reviewed changes

itsnelsonmartins suggested changes Sep 2, 2023

View reviewed changes

keyboards/pimoroni/keybow2040/info.json Outdated Show resolved Hide resolved

fanf2 force-pushed the pimoroni_keybow_2040 branch 2 times, most recently from ba17986 to cd809cb Compare September 3, 2023 17:33

drashna requested changes Sep 15, 2023

View reviewed changes

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 3, 2023

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Nov 4, 2023

zvecr requested changes Dec 10, 2023

View reviewed changes

fanf2 force-pushed the pimoroni_keybow_2040 branch from cd809cb to 214121e Compare December 11, 2023 23:23

[Keyboard] Add pimoroni/keybow2040

031b2f0

fanf2 force-pushed the pimoroni_keybow_2040 branch from 214121e to 031b2f0 Compare December 12, 2023 00:18

fauxpark requested changes Dec 12, 2023

View reviewed changes

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jan 27, 2024

github-actions bot closed this Feb 26, 2024

willoucom mentioned this pull request Jun 22, 2024

[Keyboard] Add/Update Pimoroni keybow 2040 #23986

Open

14 tasks

	# Blankety Blank chequebook and pen
	# This file intentionally left blank

	const is31_led PROGMEM g_is31_leds[RGB_MATRIX_LED_COUNT] = {
	const is31fl3731_led_t PROGMEM g_is31fl3731_leds[IS31FL3731_LED_COUNT] = {

	["GP23", "NO_PIN", "NO_PIN", "NO_PIN"]
	["GP23", null, null, null]

[Keyboard] Add Pimoroni Keybow 2040 #21481

[Keyboard] Add Pimoroni Keybow 2040 #21481

Conversation

fanf2 commented Jul 8, 2023 • edited Loading

Description

VIA

LEDs

Despite that

Types of Changes

Checklist

sigprof commented Jul 8, 2023

fanf2 commented Jul 8, 2023

sigprof commented Jul 8, 2023

drashna commented Jul 8, 2023

fanf2 commented Jul 11, 2023 • edited Loading

fanf2 commented Jul 12, 2023

fanf2 commented Jul 19, 2023

mosch commented Jul 26, 2023 • edited Loading

fanf2 commented Jul 27, 2023

mosch commented Jul 28, 2023

mosch left a comment

Choose a reason for hiding this comment

mosch commented Aug 9, 2023

drashna Aug 3, 2023 • edited Loading

Choose a reason for hiding this comment

itsnelsonmartins left a comment

Choose a reason for hiding this comment

fanf2 commented Sep 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 3, 2023

mosch commented Nov 3, 2023

willoucom commented Dec 10, 2023

keyboard-magpie commented Dec 10, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fanf2 Dec 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fauxpark Dec 12, 2023 • edited by zvecr Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fanf2 commented Dec 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 27, 2024

github-actions bot commented Feb 26, 2024

Gadgetoid commented May 15, 2024

fanf2 commented Jul 8, 2023 •

edited

Loading

fanf2 commented Jul 11, 2023 •

edited

Loading

mosch commented Jul 26, 2023 •

edited

Loading

drashna Aug 3, 2023 •

edited

Loading

fanf2 Dec 11, 2023 •

edited

Loading

fauxpark Dec 12, 2023 •

edited by zvecr

Loading