Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more qmk generate-api fallout from userspace support #22619

Merged
merged 1 commit into from
Dec 6, 2023

Commits on Dec 6, 2023

  1. Fix more qmk generate-api fallout from userspace support

    After qmk#22222 `list_keymaps(fullpath=True)` returns absolute paths which
    might point to the userspace directory tree; however, the implementation
    of `qmk generate-api` expected to get paths relative to `qmk_firmware`.
    The problem was partially fixed in qmk#22618 for the generated `url` value;
    however, the `path` value for keymaps was still incorrect (this also
    made the subsequent code overwrite the `keymap.json` files in the
    working copy instead of writing those files converted to plain JSON into
    the API output directory).
    
    Fix the `path` value for keymaps to contain the keymap path relative to
    `qmk_firmware` as it was before the userspace changes, and skip any
    userspace keymaps which might have been found.
    sigprof committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    076e085 View commit details
    Browse the repository at this point in the history