Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added neson design 810e keyboard #22883

Merged
merged 11 commits into from
Mar 30, 2024
Merged

added neson design 810e keyboard #22883

merged 11 commits into from
Mar 30, 2024

Conversation

yulei
Copy link
Contributor

@yulei yulei commented Jan 10, 2024

add neson design 810e keyboard

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [ x] Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • [x ] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 10, 2024
fauxpark
fauxpark requested changes Jan 10, 2024
View reviewed changes
keyboards/neson_design/810e/810e.h Outdated Show resolved Hide resolved
keyboards/neson_design/810e/810e.c Outdated Show resolved Hide resolved
keyboards/neson_design/810e/info.json Outdated Show resolved Hide resolved
keyboards/neson_design/810e/info.json Show resolved Hide resolved
keyboards/neson_design/810e/readme.md Outdated Show resolved Hide resolved
keyboards/neson_design/810e/readme.md Show resolved Hide resolved
keyboards/neson_design/810e/rules.mk Outdated Show resolved Hide resolved
yulei and others added 2 commits January 11, 2024 09:37
@yulei
use custom rgb driver
82f739f
@yulei @fauxpark
Apply suggestions from code review
b3da249 
Co-authored-by: Ryan <fauxpark@gmail.com>
drashna
drashna requested changes Jan 13, 2024
View reviewed changes
keyboards/neson_design/810e/mcuconf.h Outdated Show resolved Hide resolved
keyboards/neson_design/810e/config.h Outdated Show resolved Hide resolved
keyboards/neson_design/810e/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/neson_design/810e/keymaps/via/keymap.c Show resolved Hide resolved
yulei and others added 2 commits January 15, 2024 11:38
@yulei @drashna
Apply suggestions from code review
527f463 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@yulei
convert tab to spaces
fcb044d
@yulei
Copy link
Contributor Author

yulei commented Feb 25, 2024

@drashna anything blocking the review process?

waffle87
waffle87 requested changes Mar 9, 2024
View reviewed changes
keyboards/neson_design/810e/info.json Outdated Show resolved Hide resolved
keyboards/neson_design/810e/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/neson_design/810e/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/neson_design/810e/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/neson_design/810e/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/neson_design/810e/mcuconf.h Outdated Show resolved Hide resolved
keyboards/neson_design/810e/info.json Outdated Show resolved Hide resolved
keyboards/neson_design/810e/rules.mk Outdated Show resolved Hide resolved
yulei and others added 2 commits March 9, 2024 21:14
@yulei @waffle87
Apply suggestions from code review
e4562ab 
Co-authored-by: jack <0x6a73@protonmail.com>
@yulei
removed i2c related
fa68507
@fauxpark fauxpark requested a review from a team March 10, 2024 00:26
@yulei @drashna
Update keyboards/neson_design/810e/keymaps/via/keymap.c
f740451 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna merged commit ac74d10 into qmk:master Mar 30, 2024
3 checks passed
@yulei yulei mentioned this pull request Mar 30, 2024
Merged
7 tasks
xiodine32 pushed a commit to xiodine32/qmk_firmware that referenced this pull request Mar 31, 2024
@yulei @fauxpark
@drashna @waffle87 @xiodine32
[Keyboard] add neson design 810e keyboard (qmk#22883)
454ac92 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: jack <0x6a73@protonmail.com>
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@yulei @fauxpark
@drashna @waffle87
[Keyboard] add neson design 810e keyboard (qmk#22883)
2fa219b 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: jack <0x6a73@protonmail.com>
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
@yulei @fauxpark
@drashna @waffle87 @girtsf
[Keyboard] add neson design 810e keyboard (qmk#22883)
1fcf1b8 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: jack <0x6a73@protonmail.com>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@yulei @fauxpark
@drashna @waffle87 @whoisjordangarcia
[Keyboard] add neson design 810e keyboard (qmk#22883)
b6d1f1d 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 requested changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yulei @drashna @fauxpark @waffle87