Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keyboard] mechwild/bb40 #22958

Merged
merged 2 commits into from
Mar 29, 2024
Merged

[keyboard] mechwild/bb40 #22958

merged 2 commits into from
Mar 29, 2024

Conversation

lesshonor
Copy link
Contributor

Description

Adds MechWild's bb40 to the main QMK repo.

The code has been publicly available for about six months, so I've added a LAYOUT alias to avoid breaking out-of-tree keymaps.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Mar 15, 2024
@lesshonor
Copy link
Contributor Author

if someone could mark as awaiting review, that would be appreciated.

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only caveat here, is that weact now has a 8MHz crystal variant, too... But that doesn't effect this PR.

@drashna drashna removed the stale Issues or pull requests that have become inactive without resolution. label Mar 15, 2024
@drashna drashna requested a review from a team March 15, 2024 05:05
@lesshonor
Copy link
Contributor Author

Forgot that I used the soon-to-be deprecated DEFAULT_FOLDER here, so I've removed it and added more explanatory text. (dunk2k W)

Haven't run into anyone flashing the wrong version in quite some time; while proving a negative is tough, maybe folks are reading the instructions more.

@drashna drashna merged commit 4cd92ca into qmk:master Mar 29, 2024
3 checks passed
@lesshonor lesshonor deleted the new-keyboard/bb40 branch March 29, 2024 01:28
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
Co-authored-by: Kyle McCreery <mccreery.kyle@gmail.com>
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
Co-authored-by: Kyle McCreery <mccreery.kyle@gmail.com>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
Co-authored-by: Kyle McCreery <mccreery.kyle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants