Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update serial_driver.md #23035

Merged
merged 5 commits into from
Mar 30, 2024
Merged

Update serial_driver.md #23035

merged 5 commits into from
Mar 30, 2024

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Feb 7, 2024 •
edited
Loading

Description

  • wording and terms changed to prevent confusion or ambiguity, and assist language translators
  • Clarify conditions of when to use half-duplex or full-duplex
  • numbering fixed where broken
  • correct steps flow in *-duplex sections
  • confirm sooner rather than later omission of pull-up resistor for Half-duplex with RP2040

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@dunk2k
Update serial_driver.md
d1df25f 
- wording and terms changed to prevent confusion or ambiguity,  and assist language translators
- numbering fixed where broken
fauxpark
fauxpark reviewed Feb 7, 2024
View reviewed changes
docs/serial_driver.md Outdated Show resolved Hide resolved
fauxpark
fauxpark reviewed Feb 7, 2024
View reviewed changes
docs/serial_driver.md Outdated Show resolved Hide resolved
@dunk2k dunk2k requested a review from fauxpark February 15, 2024 16:09
KarlK90
KarlK90 approved these changes Feb 17, 2024
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dunk2k Thank you for the overhaul! As a non native English speaker it is too easy to miss these subtleties.

drashna
drashna reviewed Mar 15, 2024
View reviewed changes
docs/serial_driver.md Outdated Show resolved Hide resolved
docs/serial_driver.md Outdated Show resolved Hide resolved
docs/serial_driver.md Show resolved Hide resolved
docs/serial_driver.md Outdated Show resolved Hide resolved
docs/serial_driver.md Outdated Show resolved Hide resolved
@dunk2k @drashna
Apply suggestions from code review
33830f3 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna requested a review from a team March 30, 2024 00:56
@KarlK90 KarlK90 merged commit 7bff385 into qmk:master Mar 30, 2024
2 checks passed
@dunk2k dunk2k deleted the patch-1 branch March 30, 2024 09:55
xiodine32 pushed a commit to xiodine32/qmk_firmware that referenced this pull request Mar 31, 2024
@dunk2k @drashna @xiodine32
Update serial_driver.md (qmk#23035)
3fc052f 
Co-authored-by: Drashna Jaelre <drashna@live.com>
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@dunk2k @drashna
Update serial_driver.md (qmk#23035)
7706691 
Co-authored-by: Drashna Jaelre <drashna@live.com>
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
@dunk2k @drashna @girtsf
Update serial_driver.md (qmk#23035)
e541875 
Co-authored-by: Drashna Jaelre <drashna@live.com>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@dunk2k @drashna @whoisjordangarcia
Update serial_driver.md (qmk#23035)
9809700 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dunk2k @drashna @fauxpark @KarlK90