Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer text about double tapping reset only working for boot after already having QMK running in board #23042

Merged
merged 2 commits into from
Mar 30, 2024

Conversation

VictorSCamargo
Copy link
Contributor

Clearer text about double tapping reset only working for boot after already having QMK running in board.

Description

Simple change that makes it clearer. It can prevent confusion with I had. As simple as it is, as it sounds like it has something to do with having the program compiled but does not make it clear that it should already be running on the board.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • [] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Contributor

@elpekenin elpekenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Clearer text about reset only working for boot after already have QMK running
docs/flashing.md Outdated Show resolved Hide resolved
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna requested a review from a team March 30, 2024 00:55
@KarlK90 KarlK90 merged commit 696bf80 into qmk:master Mar 30, 2024
2 checks passed
xiodine32 pushed a commit to xiodine32/qmk_firmware that referenced this pull request Mar 31, 2024
…lready having QMK running in board (qmk#23042)

Co-authored-by: Drashna Jaelre <drashna@live.com>
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
…lready having QMK running in board (qmk#23042)

Co-authored-by: Drashna Jaelre <drashna@live.com>
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
…lready having QMK running in board (qmk#23042)

Co-authored-by: Drashna Jaelre <drashna@live.com>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
…lready having QMK running in board (qmk#23042)

Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants