Fixes for encoder abstraction.

[tzarc]

Description

As reported on Discord (here onwards), and subsequently #23191.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

• (Hopefully) Fixes [Bug] Encoder on slave continues to trigger forever once activated #23191.

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[jasonish]

As mentioned in Discord, this didn't help. I might poke around bit myself, but not sure if I'll get anywhere. But happy test anything. Just @ me or I'll keep an eye on this pull request.

[finrod09]

This seems to help. In the worst-case scenario of a loaded-up keymap/userspace and a pointing device on the slave, I could not observe a spurious encoder event within 30 minutes, when it occured at least once within one minute before in this scenario.

[jasonish]

This is working for me so far, the second encoder is now usable.

[ireun]

I can also confirm it's working - Sofle RGB here

[Coko7]

As mentioned in my comment on issue #23191, this fix solves the problem for me, and I have yet to face the initial problem again.
I am using a sofle/rev1 with RGB and I confirm that it is working.

[tzarc]

@finrod09 @jasonish @ireun @Coko7 once more a set of changes, would be great to confirm.

Marking it as ready for review in the meantime, hopefully if it all goes well on your end we can sort out a merge on ours.

[tzarc]

Notes for self

[ireun]

Still fine on my end, encoders on both sides of Sofle RGB working correctly. Thank You @tzarc. <3

Ψ Git branch: bugfix/encoder-abstraction
Ψ Repo version: 0.24.2
Ψ - Latest bugfix/encoder-abstraction: 2024-03-08 23:00:42 +1100 (d4eda060e3) -- Move queue drain to main thread.

[finrod09]

Sorry for the delay!

I can also confirm that it's still fine as of 5bf5fc1: I can no longer provoke encoder misbehaviour.