Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orthograph: correct layout data #23213

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Orthograph: correct layout data #23213

merged 2 commits into from
Mar 9, 2024

Conversation

noroadsleft
Copy link
Member

Description

  • corrects the key sizes and positions in the layout data
  • removes the dead space from the layout data

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

orthograph

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft
correct layout data
63c51de 
Correct the key sizes and positions in the layout data.

[chore]
@noroadsleft
remove layout offset
d0f6b21 
Remove the dead space from the layout data.

[chore]
@noroadsleft noroadsleft requested a review from a team March 4, 2024 18:58
@noroadsleft
Copy link
Member Author

cc @vladkvit (keyboard maintainer)

@vladkvit
Copy link
Contributor

vladkvit commented Mar 4, 2024

I see that this PR shifts all the key positions so that the top left key is at 0,0, and also moves the spacebars.
Could you comment on "corrects the key sizes"? Have any key sizes changed?

@noroadsleft
Copy link
Member Author

The tool that converts the KLE layout data into info.json layout data doesn't understand key rotation, so keys that are rotated in KLE end up misplaced in info.json/QMK Configurator rendering. The screenshot in the opening post is what the board looks like in QMK Configurator right now. Notice the spacebars being clumped in the lower left.

This PR moves the keys so all the keys are visible, and it's clear which key is which position. Here's a screenshot of what the board will look like in QMK Configurator with this changeset merged:
image

@zvecr zvecr merged commit fec2323 into qmk:master Mar 9, 2024
3 checks passed
@noroadsleft noroadsleft deleted the cf/orthograph branch March 10, 2024 06:52
vpadillap pushed a commit to vpadillap/qmk_firmware that referenced this pull request Mar 11, 2024
@noroadsleft @vpadillap
Orthograph: correct layout data (qmk#23213)
d5c9fd4 
* correct layout data

Correct the key sizes and positions in the layout data.

[chore]

* remove layout offset

Remove the dead space from the layout data.

[chore]
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@noroadsleft @whoisjordangarcia
Orthograph: correct layout data (qmk#23213)
b688a33 
* correct layout data

Correct the key sizes and positions in the layout data.

[chore]

* remove layout offset

Remove the dead space from the layout data.

[chore]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@noroadsleft @vladkvit @drashna @fauxpark @zvecr