Xiudi XD96 Layout Bugfixes and Touch-Up #23242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous URL linked to a Cospad listing. [chore] [docs]
The right half of split Backspace is actually located at [5, 9], not [5, 3]. [bugfix]
Corrects the matrix positions of the ISO Hash/Tilde and ISO Enter keys to [3, 12] and [3, 13], respectively. [bugfix]
[docs]
- remove "inline block" comments - grid-align keycodes - use four-space indent [style]
noroadsleft
added
enhancement
keyboard
keymap
via
7 tasks
fauxpark
approved these changes
Mar 8, 2024
vpadillap
pushed a commit
to vpadillap/qmk_firmware
that referenced
this pull request
Mar 11, 2024
* Correct AliExpress Hardware Availability link in readme Previous URL linked to a Cospad listing. [chore] [docs] * Convert `info.json` to four-space indent [style] * Correct `LAYOUT_all` matrix data The right half of split Backspace is actually located at [5, 9], not [5, 3]. [bugfix] * Correct `LAYOUT_96_iso` matrix data Corrects the matrix positions of the ISO Hash/Tilde and ISO Enter keys to [3, 12] and [3, 13], respectively. [bugfix] * Add layout/matrix diagram [docs] * Refactor keymaps - remove "inline block" comments - grid-align keycodes - use four-space indent [style]
whoisjordangarcia
pushed a commit
to whoisjordangarcia/qmk_firmware
that referenced
this pull request
Jun 8, 2024
* Correct AliExpress Hardware Availability link in readme Previous URL linked to a Cospad listing. [chore] [docs] * Convert `info.json` to four-space indent [style] * Correct `LAYOUT_all` matrix data The right half of split Backspace is actually located at [5, 9], not [5, 3]. [bugfix] * Correct `LAYOUT_96_iso` matrix data Corrects the matrix positions of the ISO Hash/Tilde and ISO Enter keys to [3, 12] and [3, 13], respectively. [bugfix] * Add layout/matrix diagram [docs] * Refactor keymaps - remove "inline block" comments - grid-align keycodes - use four-space indent [style]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous URL linked to a Cospad listing.
info.jsonto four-space indentLAYOUT_allmatrix dataThe right half of split Backspace is actually located at [5, 9], not [5, 3].
LAYOUT_96_isomatrix dataCorrects the matrix positions of the ISO Hash/Tilde and ISO Enter keys to [3, 12] and [3, 13], respectively. (Thanks to zvecr for checking this for me.)
Types of Changes
Issues Fixed or Closed by This PR
readme.mdLAYOUT_96_isoandLAYOUT_allChecklist