Add Skyloong Gk104 q1 ansi keyboard #23256
Open
+1,260
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
zvecr
requested changes
Mar 12, 2024
zvecr
reviewed
Mar 13, 2024
keyboards/skyloong/gk104/q1/config.h
Outdated
| # define WIN_LOCK_INDEX 93 | ||
| # define CAPS_LOCK_INDEX 58 | ||
| # define SCR_LOCK_INDEX 14 | ||
| # define SDB B5 |
There was a problem hiding this comment.
Why is this mapping the same pin as AW20216S_EN_PIN? It doesnt look to add any value and all references should probably be removed.
There was a problem hiding this comment.
Please don't resolve the conversation if the issue hasn't actually been addressed.
SDB looks like it should be removed.
Suggested change
| # define SDB B5 |
drashna
requested changes
Mar 15, 2024
keyboards/skyloong/gk104/q1/config.h
Outdated
| # define WIN_LOCK_INDEX 93 | ||
| # define CAPS_LOCK_INDEX 58 | ||
| # define SCR_LOCK_INDEX 14 | ||
| # define SDB B5 |
There was a problem hiding this comment.
Please don't resolve the conversation if the issue hasn't actually been addressed.
SDB looks like it should be removed.
Suggested change
| # define SDB B5 |
NaturalZh
force-pushed
the
gk104_q1_ansi
branch
from
4c5b143
to
003e170
Compare
OK, Thank you. Co-authored-by: Joel Challis <git@zvecr.com>
OK, Thank you. Co-authored-by: Joel Challis <git@zvecr.com>
OK, I see. Co-authored-by: Joel Challis <git@zvecr.com>
OK, I see. Co-authored-by: Joel Challis <git@zvecr.com>
OK, Thank you. Co-authored-by: Joel Challis <git@zvecr.com>
OK, Thank you. Co-authored-by: Joel Challis <git@zvecr.com>
OK, I see. Thank you very much. Co-authored-by: Joel Challis <git@zvecr.com>
Yes, SPI1 didn`t be used. Thank you. Co-authored-by: Joel Challis <git@zvecr.com>
OK, Thank you. Co-authored-by: Drashna Jaelre <drashna@live.com>
OK, Thank you. Co-authored-by: Drashna Jaelre <drashna@live.com>
|
What can I do for this PR else ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a skyloong gk104 q1 ansi keyboard
Description
The Skyloong GK104 Q1 keyboard is an RGB matrix keyboard with LED digital display.
Types of Changes
Issues Fixed or Closed by This PR
Checklist