Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag LAYOUT macros still defined in .h files #23260

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Flag LAYOUT macros still defined in .h files #23260

merged 1 commit into from
Mar 12, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 11, 2024

Description

Has been a PR requirement for a long time now, yet we still get many a PR with them specified in code.

This still allows qmk info -f json to render the output, so it can be copy-pasted to the correct location.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Mar 12, 2024
@tzarc tzarc merged commit ae38bdd into master Mar 12, 2024
4 of 5 checks passed
@tzarc tzarc deleted the flag_h_layouts branch March 12, 2024 04:28
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants