Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Magicforce MF17 RGB matrix #23263

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Fix Magicforce MF17 RGB matrix #23263

merged 2 commits into from
Mar 12, 2024

Conversation

GalaxyAllie
Copy link
Contributor

Description

Fix Magicforce MF17 RGB matrix so the keys trigger the correct LED. I have tested this on my MF17 RGB.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team March 12, 2024 04:26
@waffle87 waffle87 merged commit 654dc26 into qmk:master Mar 12, 2024
3 checks passed
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@GalaxyAllie
Fix Magicforce MF17 RGB matrix (qmk#23263)
fc91df5
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
@GalaxyAllie @girtsf
Fix Magicforce MF17 RGB matrix (qmk#23263)
cc6a3d5
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@GalaxyAllie @whoisjordangarcia
Fix Magicforce MF17 RGB matrix (qmk#23263)
a24ec73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GalaxyAllie @fauxpark @waffle87