Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add handwired keyboard: Nanggong #23265

Closed
wants to merge 34 commits into from
Closed

add handwired keyboard: Nanggong #23265

wants to merge 34 commits into from

Conversation

SanmaLD
Copy link

@SanmaLD SanmaLD commented Mar 12, 2024

Add Nanggong Keyboard

Description

nanggong
Nanggong is a 63-key/60% ortholinear keyboard built using Arduino Pro Micro Atmega32u4 and QMK Firmware, and firmware has been built to support VIA Software and supports underglow WS2812/WS2812b.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@SanmaLD
Add Nanggong Keyboard
e1fc2b1 
Add Nanggong Keyboard
@SanmaLD
Create readme.md
b9dec97 
add Documentation
@SanmaLD
Fix directory file nanggong keyboard
19bef53 
Fix directory file to be handwiring nanggong keyboard
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 12, 2024
@SanmaLD SanmaLD changed the title Nanggong add handwired keyboard: Nanggong Mar 12, 2024
@SanmaLD
Fix lint license header
4156f18 
add license header
waffle87
waffle87 requested changes Mar 12, 2024
View reviewed changes
keyboards/handwired/nanggong/config.h Outdated Show resolved Hide resolved
keyboards/handwired/nanggong/info.json Show resolved Hide resolved
keyboards/handwired/nanggong/info.json Outdated Show resolved Hide resolved
keyboards/handwired/nanggong/info.json Outdated Show resolved Hide resolved
keyboards/handwired/nanggong/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/nanggong/keymaps/via/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/nanggong/nanggong.json Outdated Show resolved Hide resolved
keyboards/handwired/nanggong/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/nanggong/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/nanggong/info.json Show resolved Hide resolved
@SanmaLD
Update config.h
0575e02 
Remove RGBLIGHT_LAYERS & add NO_ACTION_ONESHOT
@SanmaLD
Update info.json
7b4510b 
add qmk locking, build, features and change board info
@SanmaLD
Update keymap.c
9f25d02 
Fix default keymap
@SanmaLD
Update rules.mk
a55711a 
Fix VIA rules
@SanmaLD
Update readme.md
7ee74bd 
Fix image readme
@SanmaLD
Update rules.mk
1ab60f7 
Remove default rules
@SanmaLD SanmaLD requested a review from waffle87 March 12, 2024 19:10
@SanmaLD
Update keymap.c
b1f9118 
Remove RGBLIGHT_LAYER_SEGMENTS
@SanmaLD
Update config.h
d4c795c 
Add license
@SanmaLD SanmaLD requested a review from waffle87 March 12, 2024 19:57
@SanmaLD
Add Nanggong Keyboard
875a9fd 
Add Nanggong Keyboard
@SanmaLD
Create readme.md
7ae41c1 
add Documentation
@SanmaLD
Fix directory file nanggong keyboard
1349364 
Fix directory file to be handwiring nanggong keyboard
@SanmaLD
Fix lint license header
70270f7 
add license header
@SanmaLD
Update config.h
4335467 
Remove RGBLIGHT_LAYERS & add NO_ACTION_ONESHOT
@SanmaLD
Update info.json
b46b769 
add qmk locking, build, features and change board info
@SanmaLD
Update keymap.c
e6760d2 
Fix default keymap
SanmaLD and others added 6 commits March 13, 2024 11:39
@SanmaLD
Update rules.mk
b354a44 
Fix VIA rules
@SanmaLD
Update readme.md
871b915 
Fix image readme
@SanmaLD
Update rules.mk
aae1035 
Remove default rules
@SanmaLD
Update keymap.c
f3c6649 
Remove RGBLIGHT_LAYER_SEGMENTS
@SanmaLD
Update config.h
90ecdce 
Add license
@SanmaLD
Delete keyboards/handwired/nanggong/nanggong.json
a161906 
Delete via file
@SanmaLD SanmaLD requested a review from zvecr March 13, 2024 04:40
@drashna drashna requested a review from a team March 15, 2024 01:36
fauxpark
fauxpark requested changes Mar 15, 2024
View reviewed changes
keyboards/handwired/nanggong/info.json Outdated
"knight": true,
"christmas": false,
"static_gradient": true,
"rgb_test": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"rgb_test": true,

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fauxpark Thank sir for checking my PR. I have made the changes according to your review. Thank you.

@SanmaLD SanmaLD requested a review from fauxpark March 15, 2024 14:10
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Apr 30, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@waffle87 waffle87 Awaiting requested review from waffle87

@zvecr zvecr Awaiting requested review from zvecr

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SanmaLD @drashna @fauxpark @zvecr @waffle87