Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acceleration reset on overlapping mouse keys #23269

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

esawady
Copy link

@esawady esawady commented Mar 13, 2024

See #21494. Prior to this fix, moving the mouse diagonally would skip the first MOUSEKEY_MOVE_DELTA frames of acceleration.

Description

I'm not entirely sure this is the behavior we want - resetting acceleration when going from eg. moving up to moving up-right doesn't seem quite right. However, I'm pretty confident that this is what the original patch was meant to do.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

See qmk#21494. Prior to this fix,
moving the mouse diagonally would skip the first MOUSEKEY_MOVE_DELTA
frames of acceleration.
@github-actions github-actions bot added the core label Mar 13, 2024
@filterpaper
Copy link
Contributor

filterpaper commented Mar 21, 2024

I'm pretty confident that this is what the original patch was meant to do.

#21494 was designed to reduce (jarring) continual increase in acceleration with a new direction. Reseting both values to restart completely from zero, however, was not the original intent.

resetting acceleration when going from eg. moving up to moving up-right doesn't seem quite right

This (default) behaviour can be polarising due to user preference. Created #23341 as an enhancement to make this feature optional for users.

Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants