KPRepublic JJ50 rev1 Refactor #23294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[docs]
[enhancement]
[enhancement]
[enhancement]
[enhancement]
Also deletes `rules.mk` as it's no longer needed. [chore] [enhancement]
noroadsleft
added
enhancement
keyboard
keymap
via
github-actions
bot
added
dd
waffle87
approved these changes
Mar 16, 2024
zvecr
approved these changes
Mar 16, 2024
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Apr 4, 2024
* Move `kprepublic/jj50` to `kprepublic/jj50/rev1` [chore] * Add layout/matrix diagram [docs] * Add `LAYOUT_ortho_5x12_1x2u_c` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_l` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_r` [enhancement] * Add `LAYOUT_ortho_5x12_2x2u` [enhancement] * Convert `rules.mk` to data driven [chore] * Remove `console` and `command` from keyboard level [chore] * Rename `info.json` to `keyboard.json` Also deletes `rules.mk` as it's no longer needed. [chore] [enhancement]
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Apr 4, 2024
* Move `kprepublic/jj50` to `kprepublic/jj50/rev1` [chore] * Add layout/matrix diagram [docs] * Add `LAYOUT_ortho_5x12_1x2u_c` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_l` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_r` [enhancement] * Add `LAYOUT_ortho_5x12_2x2u` [enhancement] * Convert `rules.mk` to data driven [chore] * Remove `console` and `command` from keyboard level [chore] * Rename `info.json` to `keyboard.json` Also deletes `rules.mk` as it's no longer needed. [chore] [enhancement]
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Apr 15, 2024
* Move `kprepublic/jj50` to `kprepublic/jj50/rev1` [chore] * Add layout/matrix diagram [docs] * Add `LAYOUT_ortho_5x12_1x2u_c` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_l` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_r` [enhancement] * Add `LAYOUT_ortho_5x12_2x2u` [enhancement] * Convert `rules.mk` to data driven [chore] * Remove `console` and `command` from keyboard level [chore] * Rename `info.json` to `keyboard.json` Also deletes `rules.mk` as it's no longer needed. [chore] [enhancement]
0x647262
pushed a commit
to 0x647262/qmk_firmware
that referenced
this pull request
Apr 26, 2024
* Move `kprepublic/jj50` to `kprepublic/jj50/rev1` [chore] * Add layout/matrix diagram [docs] * Add `LAYOUT_ortho_5x12_1x2u_c` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_l` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_r` [enhancement] * Add `LAYOUT_ortho_5x12_2x2u` [enhancement] * Convert `rules.mk` to data driven [chore] * Remove `console` and `command` from keyboard level [chore] * Rename `info.json` to `keyboard.json` Also deletes `rules.mk` as it's no longer needed. [chore] [enhancement]
PepperLola
pushed a commit
to PepperLola/qmk_firmware
that referenced
this pull request
May 29, 2024
* Move `kprepublic/jj50` to `kprepublic/jj50/rev1` [chore] * Add layout/matrix diagram [docs] * Add `LAYOUT_ortho_5x12_1x2u_c` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_l` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_r` [enhancement] * Add `LAYOUT_ortho_5x12_2x2u` [enhancement] * Convert `rules.mk` to data driven [chore] * Remove `console` and `command` from keyboard level [chore] * Rename `info.json` to `keyboard.json` Also deletes `rules.mk` as it's no longer needed. [chore] [enhancement]
whoisjordangarcia
pushed a commit
to whoisjordangarcia/qmk_firmware
that referenced
this pull request
Jun 8, 2024
* Move `kprepublic/jj50` to `kprepublic/jj50/rev1` [chore] * Add layout/matrix diagram [docs] * Add `LAYOUT_ortho_5x12_1x2u_c` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_l` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_r` [enhancement] * Add `LAYOUT_ortho_5x12_2x2u` [enhancement] * Convert `rules.mk` to data driven [chore] * Remove `console` and `command` from keyboard level [chore] * Rename `info.json` to `keyboard.json` Also deletes `rules.mk` as it's no longer needed. [chore] [enhancement]
nuphy-src
pushed a commit
to nuphy-src/qmk_firmware
that referenced
this pull request
Jul 2, 2024
* Move `kprepublic/jj50` to `kprepublic/jj50/rev1` [chore] * Add layout/matrix diagram [docs] * Add `LAYOUT_ortho_5x12_1x2u_c` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_l` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_r` [enhancement] * Add `LAYOUT_ortho_5x12_2x2u` [enhancement] * Convert `rules.mk` to data driven [chore] * Remove `console` and `command` from keyboard level [chore] * Rename `info.json` to `keyboard.json` Also deletes `rules.mk` as it's no longer needed. [chore] [enhancement]
AJO-Python
pushed a commit
to AJO-Python/qmk_firmware
that referenced
this pull request
Jul 7, 2024
* Move `kprepublic/jj50` to `kprepublic/jj50/rev1` [chore] * Add layout/matrix diagram [docs] * Add `LAYOUT_ortho_5x12_1x2u_c` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_l` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_r` [enhancement] * Add `LAYOUT_ortho_5x12_2x2u` [enhancement] * Convert `rules.mk` to data driven [chore] * Remove `console` and `command` from keyboard level [chore] * Rename `info.json` to `keyboard.json` Also deletes `rules.mk` as it's no longer needed. [chore] [enhancement]
jrtex
pushed a commit
to jrtex/qmk_firmware
that referenced
this pull request
Jul 13, 2024
* Move `kprepublic/jj50` to `kprepublic/jj50/rev1` [chore] * Add layout/matrix diagram [docs] * Add `LAYOUT_ortho_5x12_1x2u_c` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_l` [enhancement] * Add `LAYOUT_ortho_5x12_1x2u_r` [enhancement] * Add `LAYOUT_ortho_5x12_2x2u` [enhancement] * Convert `rules.mk` to data driven [chore] * Remove `console` and `command` from keyboard level [chore] * Rename `info.json` to `keyboard.json` Also deletes `rules.mk` as it's no longer needed. [chore] [enhancement]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
kprepublic/jj50tokprepublic/jj50/rev1rules.mkto data drivenconsoleandcommandfrom keyboard-level configurationinfo.jsontokeyboard.jsonrev1/rules.mkTypes of Changes
Checklist