New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds keyboard ergodox_extended #23340
base: master
Are you sure you want to change the base?
Conversation
I think that's everything, if I missed anything please let me know and I'll get it sorted asap. |
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Part 2 Co-authored-by: jack <0x6a73@protonmail.com>
Alrighty, got all those changes committed. How are we looking? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to be unused, though i havent built locally to verify
Anything left to do here? |
I think this is ready for review/merge, all the changes requested have been made and it's looking pretty sharp. If there's anything else I need on it, let me know and I can get it fixed up immediately. |
Ready for merge? |
Done. I think that should be the last thing, right? |
Good morning! This is ready for a review. Let me know if anything else needs to be changed. I'd love to get this merged this week if possible. |
Anyone free to have a look at this and let me know if anything else needs to be changed? |
(note: I don't know enough about the custom matrix to comment on it one way or the other, but everything else seems fine.) |
At the very least, the custom matrix works as intended. I've been typing on it for a bit. |
This has been approved for a month. Can I get this merged in? |
Description
This adds the Ergodox Extended, a version of the ErgoDox that adds F-keys and expands the thumb cluster. Keyboard hardware repo is here. Firmware is almost entirely based on
keyboards/handwired/pterodactyl
, since that was very cleanly written and easy to modify.Types of Changes
Issues Fixed or Closed by This PR
Checklist