Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds keyboard ergodox_extended #23340

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

Gephorian
Copy link

@Gephorian Gephorian commented Mar 24, 2024

Description

This adds the Ergodox Extended, a version of the ErgoDox that adds F-keys and expands the thumb cluster. Keyboard hardware repo is here. Firmware is almost entirely based on keyboards/handwired/pterodactyl, since that was very cleanly written and easy to modify.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Gephorian
Copy link
Author

I think that's everything, if I missed anything please let me know and I'll get it sorted asap.

@Gephorian Gephorian changed the title Ergodox extended Adds keyboard ergodox_extended Mar 25, 2024
keyboards/ergodox_extended/info.json Show resolved Hide resolved
keyboards/ergodox_extended/rules.mk Outdated Show resolved Hide resolved
keyboards/ergodox_extended/info.json Show resolved Hide resolved
Gephorian and others added 3 commits March 24, 2024 20:10
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Part 2

Co-authored-by: jack <0x6a73@protonmail.com>
@Gephorian Gephorian requested a review from waffle87 March 25, 2024 01:11
@waffle87 waffle87 requested a review from a team March 25, 2024 01:34
keyboards/ergodox_extended/keymaps/Gephorian/keymap.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/info.json Outdated Show resolved Hide resolved
@Gephorian Gephorian requested a review from fauxpark March 25, 2024 02:35
@Gephorian Gephorian requested a review from fauxpark March 26, 2024 14:09
keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/matrix.c Show resolved Hide resolved
keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/info.json Outdated Show resolved Hide resolved
@Gephorian
Copy link
Author

Alrighty, got all those changes committed. How are we looking?

Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be unused, though i havent built locally to verify

keyboards/ergodox_extended/matrix.c Show resolved Hide resolved
keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
@Gephorian Gephorian requested a review from zvecr March 26, 2024 14:46
@Gephorian
Copy link
Author

Anything left to do here?

@Gephorian
Copy link
Author

I think this is ready for review/merge, all the changes requested have been made and it's looking pretty sharp. If there's anything else I need on it, let me know and I can get it fixed up immediately.

keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
keyboards/ergodox_extended/matrix.c Outdated Show resolved Hide resolved
@Gephorian Gephorian requested a review from fauxpark March 27, 2024 02:35
@Gephorian
Copy link
Author

Ready for merge?

@Gephorian
Copy link
Author

Done. I think that should be the last thing, right?

@Gephorian Gephorian requested a review from zvecr March 27, 2024 14:25
@Gephorian
Copy link
Author

Good morning! This is ready for a review. Let me know if anything else needs to be changed. I'd love to get this merged this week if possible.

@Gephorian Gephorian requested a review from waffle87 March 28, 2024 19:15
@Gephorian
Copy link
Author

Anyone free to have a look at this and let me know if anything else needs to be changed?

@lesshonor
Copy link
Contributor

(note: I don't know enough about the custom matrix to comment on it one way or the other, but everything else seems fine.)

@Gephorian
Copy link
Author

At the very least, the custom matrix works as intended. I've been typing on it for a bit.

@Gephorian
Copy link
Author

This has been approved for a month. Can I get this merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants