Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add MIIIW BlackIO98 #23387

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ArthurCyy
Copy link
Contributor

Description

Add MIIIW BlackIO98. This is another version of BlackIO83.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 1, 2024
@lokher
Copy link
Contributor

lokher commented Apr 5, 2024

The keyboard advertises bluetooth and wireless support, but code seems doesn't .

@ArthurCyy
Copy link
Contributor Author

The keyboard advertises bluetooth and wireless support, but code seems doesn't .

#18485

@tzarc
Copy link
Member

tzarc commented Apr 5, 2024

The keyboard advertises bluetooth and wireless support, but code seems doesn't .

#18485

#18485 says that Wireless builds including QMK are bound by GPL. It does not say "you are free to release open-source code without wireless", especially if you're still using QMK internally.

Providing sources to everything except Wireless when using QMK does not comply with GPL, and as such the manufacturer is in breach of QMK's licensing. Providing full sources including Wireless bindings is required.


TL;DR:

  • Did you use QMK to build and distribute a wired keyboard? Manufacturer must provide entire source code.
  • Did you use QMK to build and distribute a wireless keyboard? Manufacturer must provide entire source code.
  • Did you use any portion of QMK to build and distribute any kind of keyboard? Manufacturer must provide entire source code.

The last point includes things such as taking and modifying via.c and hosting it in another keyboard firmware.

@ArthurCyy
Copy link
Contributor Author

ArthurCyy commented Apr 5, 2024

The keyboard advertises bluetooth and wireless support, but code seems doesn't .

#18485

#18485 says that Wireless builds including QMK are bound by GPL. It does not say "you are free to release open-source code without wireless", especially if you're still using QMK internally.

Providing sources to everything except Wireless when using QMK does not comply with GPL, and as such the manufacturer is in breach of QMK's licensing. Providing full sources including Wireless bindings is required.

TL;DR:

  • Did you use QMK to build and distribute a wired keyboard? Manufacturer must provide entire source code.
  • Did you use QMK to build and distribute a wireless keyboard? Manufacturer must provide entire source code.
  • Did you use any portion of QMK to build and distribute any kind of keyboard? Manufacturer must provide entire source code.

The last point includes things such as taking and modifying and hosting it in another keyboard firmware.via.c

  1. I am just a user of this keyboard, not the manufacturer.
  2. It seems that the wireless function of this keyboard is controlled by another main control chip and firmware (not QMK), and a physical switch on the keyboard can be flipped to switch it to wireless mode and access another firmware. I also found some information from the official firmware updater given for the wireless function, the wireless solution provider is SY Tech. Co., Ltd.
  3. Since I am not the manufacturer of this keyboard and do not have access to the source code for the wireless part, I can do nothing about the wireless part, but can only make sure that the wired part works properly. If this does not meet your requirements, I will close this PR, and I'm sorry for causing you any trouble.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that nothing in this file is actually used/has implementation anywhere, it should be removed.

* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

#include "blackio98.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include "blackio98.h"
#include "quantum.h"

Comment on lines 43 to 45
extern void ws2812_poweron(void);
extern void ws2812_poweroff(void);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
extern void ws2812_poweron(void);
extern void ws2812_poweroff(void);

Comment on lines 1 to 20
/* Copyright 2020 QMK
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

/*
* This file was auto-generated by:
* `qmk chibios-confmigrate -i keyboards/geekboards/macropad_v2/halconf.h -r platforms/chibios/common/configs/halconf.h`
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* Copyright 2020 QMK
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
/*
* This file was auto-generated by:
* `qmk chibios-confmigrate -i keyboards/geekboards/macropad_v2/halconf.h -r platforms/chibios/common/configs/halconf.h`
*/
// Copyright 2024 QMK
// SPDX-License-Identifier: GPL-2.0-or-later

Comment on lines 3 to 4
![BlackIO98](https://i.imgur.com/XY3AahEh.jpg)
![BlackIO98](https://i.imgur.com/WlWAeC9h.jpg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![BlackIO98](https://i.imgur.com/XY3AahEh.jpg)
![BlackIO98](https://i.imgur.com/WlWAeC9h.jpg)
![BlackIO98](https://i.imgur.com/XY3AahE.jpg)
![BlackIO98](https://i.imgur.com/WlWAeC9.jpg)

@ArthurCyy ArthurCyy requested a review from waffle87 April 5, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants