Added noll/multisteno #23431
Open
Added noll/multisteno #23431
+333
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Configurator is a very poor tool for such a keyboard. Technically you can PR someone else's code but copyright needs to be preserved and added to by you. However, the code you have submitted requires significant updates to be valid. Some insight to this can be seen in why the Lint checks and CI checks are failing below. You also need to go through the PR checklist carefully, and ensure you have actioned all the relevant points in it, and then check the box in the Checklist above. Only then will it be considered ready for initial review. |
waffle87
requested changes
Apr 6, 2024
zvecr
requested changes
Apr 7, 2024
zvecr
requested changes
Apr 7, 2024
Co-authored-by: jack <0x6a73@protonmail.com>
changes for pr - pass 1
We don't need the combo-events, as these were taken from the ecosteno which used combos to like a butterstick
igniuss
force-pushed
the
noll/multisteno-compatibility
branch
from
70a3007
to
0030ff9
Compare
|
I just want to thank you so much @zvecr for the time and patience; doing all of this is very overwhelming, and your assistance is super appreciated 😍 |
waffle87
reviewed
Apr 12, 2024
waffle87
requested changes
Apr 12, 2024
Co-authored-by: jack <0x6a73@protonmail.com>
waffle87
approved these changes
Apr 16, 2024
zvecr
removed
invalid
pr_checklist_pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new keyboard, so I can use the QMK configurator,
the main problem is that I do not own this keyboard, but it hasn't been updated since QMK 1.1.1, so I'm not sure what the etiquette for that is.
Types of Changes
Issues Fixed or Closed by This PR
Checklist