Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add Typface Univers #23664

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

itsme-zeix
Copy link
Contributor

Description

Added support for Typface Univers.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 5, 2024
keyboards/zeix/typface/univers/rules.mk Outdated Show resolved Hide resolved
itsme-zeix and others added 2 commits May 5, 2024 20:27
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@drashna drashna requested a review from a team May 19, 2024 04:42
@itsme-zeix itsme-zeix requested a review from dunk2k June 7, 2024 10:47
@dunk2k
Copy link
Contributor

dunk2k commented Jun 7, 2024

To confirm to how build markers have been reworked as of most recent breaking changes, can:

  1. rules.mk be removed
  2. info.json re-named to keyboard.json

keyboards/zeix/typface/univers/info.json Outdated Show resolved Hide resolved
keyboards/zeix/typface/univers/info.json Outdated Show resolved Hide resolved
keyboards/zeix/typface/univers/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/zeix/typface/univers/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/zeix/typface/univers/info.json Outdated Show resolved Hide resolved
@dunk2k
Copy link
Contributor

dunk2k commented Jun 7, 2024

Based on store page, this PCB comes in to two variants - can the directory structure of this PR be change to reflect variants available.

itsme-zeix and others added 2 commits June 9, 2024 23:59
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@itsme-zeix
Copy link
Contributor Author

To confirm to how build markers have been reworked as of most recent breaking changes, can:

  1. rules.mk be removed
  2. info.json re-named to keyboard.json

Will make these changes, thank you for notifying me about the breaking changes!

Based on store page, this PCB comes in to two variants - can the directory structure of this PR be change to reflect variants available.

The firmware supports both the solder and hotswap variant, though the hotswap variant does not include ISO compatibility - in that case, is there still a need to duplicate the files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants