Add KiiBOOM Cybrix16 #23723
Add KiiBOOM Cybrix16 #23723
Conversation
github-actions
bot
added
keyboard
keymap
via
There was a problem hiding this comment.
All of the settings in here can be moved to info.json, and this file can be removed. qmk migrate or qmk info -f json can help with that.
| setPinOutput(B8); | ||
| writePinLow(B8); | ||
| setPinOutput(B6); | ||
| writePinLow(B6); | ||
| setPinOutput(B7); | ||
| writePinLow(B7); | ||
|
|
||
| setPinOutput(B12); | ||
| writePinLow(B12); | ||
| setPinOutput(B13); | ||
| writePinLow(B13); | ||
| setPinOutput(B14); | ||
| writePinHigh(B14); |
There was a problem hiding this comment.
Is there a reason for init'ing these?
There was a problem hiding this comment.
Please run qmk format-json on this file.
There was a problem hiding this comment.
This has a bunch of tabs. Please replace tabs with spaces per coding conventions.
There was a problem hiding this comment.
As other keymap, tabs -> spaces
|
|
||
|
|
||
| ), | ||
| [2] = LAYOUT( |
There was a problem hiding this comment.
| [2] = LAYOUT( | |
| [2] = LAYOUT_ortho_4x4( |
|
|
||
|
|
||
| ), | ||
| [3] = LAYOUT( |
There was a problem hiding this comment.
| [3] = LAYOUT( | |
| [3] = LAYOUT_ortho_4x4( |
|
|
||
|
|
||
| ), | ||
| [4] = LAYOUT( |
There was a problem hiding this comment.
| [4] = LAYOUT( | |
| [4] = LAYOUT_ortho_4x4( |
|
|
||
|
|
||
| ), | ||
| [5] = LAYOUT( |
There was a problem hiding this comment.
| [5] = LAYOUT( | |
| [5] = LAYOUT_ortho_4x4( |
| @@ -0,0 +1,7 @@ | |||
|
|
|||
| MCU_LDSCRIPT = STM32F103xB | |||
| ENCODER_MAP_ENABLE = yes | |||
There was a problem hiding this comment.
Encoder map should only be enabled at the keymap level, never at the keyboard level.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist