Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lisa #24005

Closed
wants to merge 4 commits into from
Closed

Update Lisa #24005

wants to merge 4 commits into from

Conversation

key10iq
Copy link
Contributor

@key10iq key10iq commented Jun 28, 2024

Description

My update adds the ability to configure the indicator LEDs function directly from VIA

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Updated keyboard - keyten/lisa

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@waffle87
Copy link
Member

Unfortunately this cannot be accepted, as custom VIA indicator code is not currently not accepted to the qmk_firmware repository due to the maintenance burden it poses.

@key10iq
Copy link
Contributor Author

key10iq commented Jun 28, 2024

Unfortunately this cannot be accepted, as custom VIA indicator code is not currently not accepted to the qmk_firmware repository due to the maintenance burden it poses.

Is this considered a custom VIA code?
https://github.com/key10iq/keyboards/blob/Lisa/v3/keyten/lisa/lisa.json

This is controlled like a regular multilayout

@zvecr
Copy link
Member

zvecr commented Jun 29, 2024

From the PR checklist:

keyboard updates and refactors (eg. to data driven) must go through develop to reduce master -> develop merge conflicts

And with https://docs.qmk.fm/ChangeLog/20240526#migration-of-via-keymaps-to-via-team-control, we would certainly not be accepting any further keyboard level via customisation.

@key10iq
Copy link
Contributor Author

key10iq commented Jun 29, 2024

Got it, thanks

@key10iq key10iq closed this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants