Add QMK Configurator support and remove Layouts definitions #2977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
changed the title
|
I haven't removed any support. I've actually added a new layout |
|
60_ansi/60_iso to ansi/iso? |
|
Oh the renames? Yes I renamed them so people don't try to use userspace stuff without knowing about the unique RGB situation. |
|
Ah. (also, "layouts", not "userspace"... that's going to bug me) But I think it should still be part of the layout scheme. That's what conditional defines are for. @jackhumbert, opinion? |
|
Use standard layout but remove community layout support (Add a note about it) after conversation with @jackhumbert. |
jackhumbert
approved these changes
May 17, 2018
|
Thanks! |
carlpehrson
pushed a commit
to carlpehrson/qmk_firmware
that referenced
this pull request
May 30, 2018
* Add QMK Configurator support and remove userspace definitions * fix that build breakage * Unsupport community layouts but use standard layouts
hauleth
pushed a commit
to hauleth/qmk_firmware
that referenced
this pull request
Jan 24, 2019
* Add QMK Configurator support and remove userspace definitions * fix that build breakage * Unsupport community layouts but use standard layouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.