Adds basic support for u/flehrad's bigswitch pcb #3015
Conversation
- also adds support for OSX Eject/Power The function of this key depends on the version of OSX and if you have physical media. For a macbook pro 2017 holding this key down brings up the shutdown dialog. If you wrap it in LCTL and LSFT the screenlock turns on immediately.
keyboards/bigswitch/bigswitch.h
Outdated
|
|
||
| #include "quantum.h" | ||
|
|
||
| #define KEYMAP( \ |
There was a problem hiding this comment.
Can we change this over to LAYOUT.
|
|
||
| const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | ||
|
|
||
| KEYMAP(LOCK_OSX), |
There was a problem hiding this comment.
We'll have to change this over to LAYOUT here as well
- add a code for OSX Sleep
yanfali
force-pushed
the
yanfali-bigswitch-pcb
branch
from
b826cc4
to
5311bfb
Compare
yanfali
force-pushed
the
yanfali-bigswitch-pcb
branch
from
5311bfb
to
293128e
Compare
|
You should put an info.json in this too. If you can, I'd like to see the 1u key BIG as well lol. |
|
kk |
|
|
|
It needs to be atleast 4x the size of a regular 1u to match the 4x size of a Kailh x Novelkeyz big switch. =P. That looks fine |
tmk_core/common/keycode.h
Outdated
| @@ -412,6 +412,7 @@ enum hid_keyboard_keypad_usage { | |||
| /* Special keycodes */ | |||
| /* NOTE: 0xA5-DF and 0xE8-FF are used for internal special purpose */ | |||
| enum internal_special_keycodes { | |||
| KC_OSX_EJECT = 0x66, | |||
There was a problem hiding this comment.
@jackhumbert is this okay to add here?
There was a problem hiding this comment.
Yeah I stuck it in special, because it seemed like the short bus kind.
There was a problem hiding this comment.
lol.
Well, it's a core value, so I'm not sure if Jack wants it in there or not.
If you want, pull this out and add #define KC_OSX_EJECT 0x66 to your keymap instead, and create a seperate pull request for the keycode.h file.
I would recommend this, that way, I can feel okay about merging this immediately, and we can see about adding this in officially, later.
There was a problem hiding this comment.
Wait, if I'm reading that right, this is normally KC_POWER:
qmk_firmware/tmk_core/common/keycode.h
Line 283 in 5018892
So maybe #define KC_OSX_EJECT KC_POWER in your keymap would work, as well.
|
|
||
|
|
||
| # Boot Section Size in *bytes* | ||
| OPT_DEFS += -DBOOTLOADER_SIZE=4096 |
There was a problem hiding this comment.
Do you know what bootloader is in use here?
There was a problem hiding this comment.
Then if would definitely be best to use BOOTLOADER = caterina here, rather than opt_defs, since there is some specially handling for this bootloader.
| along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| #include "../../bigswitch.h" |
There was a problem hiding this comment.
This should be #include "QMK_KEYBOARD_H", but I think you said that you had some issues when it was?
There was a problem hiding this comment.
let me switch it over
|
Feel free to squash this commit |
|
Sounds good
…On Tue, May 22, 2018, 13:13 Drashna Jaelre ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tmk_core/common/keycode.h
<#3015 (comment)>:
> @@ -412,6 +412,7 @@ enum hid_keyboard_keypad_usage {
/* Special keycodes */
/* NOTE: 0xA5-DF and 0xE8-FF are used for internal special purpose */
enum internal_special_keycodes {
+ KC_OSX_EJECT = 0x66,
lol.
Well, it's a core value, so I'm not sure if Jack wants it in there or not.
If you want, pull this out and add #define KC_OSX_EJECT 0x66 to your
keymap instead, and create a seperate pull request for the keycode.h file.
I would recommend this, that way, I can feel okay about merging this
immediately, and we can see about adding this in officially, later.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3015 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACK5U0Sn8axZGySbCp_WuOXG4PL_vLT7ks5t1HFcgaJpZM4UH_Ft>
.
|
|
@drashna I've moved the Eject keycode to the keymap. Please squash before merge. |
|
Thanks! |
* Adds basic support for u/flehrad's bigswitch pcb - also adds support for OSX Eject/Power The function of this key depends on the version of OSX and if you have physical media. For a macbook pro 2017 holding this key down brings up the shutdown dialog. If you wrap it in LCTL and LSFT the screenlock turns on immediately. * Switch to Layout Macro - add a code for OSX Sleep * Add a README * Turn on RGB by default * Add info.json * Address comments by @drashna * Only define Eject in keymap
* Adds basic support for u/flehrad's bigswitch pcb - also adds support for OSX Eject/Power The function of this key depends on the version of OSX and if you have physical media. For a macbook pro 2017 holding this key down brings up the shutdown dialog. If you wrap it in LCTL and LSFT the screenlock turns on immediately. * Switch to Layout Macro - add a code for OSX Sleep * Add a README * Turn on RGB by default * Add info.json * Address comments by @drashna * Only define Eject in keymap
* Adds basic support for u/flehrad's bigswitch pcb - also adds support for OSX Eject/Power The function of this key depends on the version of OSX and if you have physical media. For a macbook pro 2017 holding this key down brings up the shutdown dialog. If you wrap it in LCTL and LSFT the screenlock turns on immediately. * Switch to Layout Macro - add a code for OSX Sleep * Add a README * Turn on RGB by default * Add info.json * Address comments by @drashna * Only define Eject in keymap
The function of this key depends on the version of OSX and if you
have physical media. For a macbook pro 2017 holding this key down
brings up the shutdown dialog. If you wrap it in LCTL and LSFT the
screenlock turns on immediately.