Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AL1 keyboard to QMK #3049

Closed
wants to merge 1 commit into from
Closed

Add AL1 keyboard to QMK #3049

wants to merge 1 commit into from

Conversation

olivia
Copy link
Contributor

@olivia olivia commented May 25, 2018 •
edited

  • Move over folder from AL1 Repo
  • Add instructions to flash since default keymap is missing reset key
  • Add better keymap with reset key

mechmerlin
mechmerlin reviewed May 25, 2018
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think QMK already has support for all the custom code in matrix.c. You could try removing that file and see if things still work out for you. Unless of course the AL1 does indeed use some custom matrix stuff.

keyboards/al1/al1.h
DDRD |= (1<<0) | (1<<1);


#define KEYMAP( \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename KEYMAP to LAYOUT_all in this .h file and in the keymap.c files that reference it?

keyboards/al1/al1.h
{ K500, K501, K502, K503, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO} \
}

#define KEYMAP_SPLITBS( \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename this to LAYOUT_split_bs and in the keymap.c files that reference it?

keyboards/al1/keymaps/default/keymap.c
@@ -0,0 +1,56 @@
#include "al1.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace #include "all.h with #include QMK_KEYBOARD_H

keyboards/al1/keymaps/default/keymap.c
#include "al1.h"

const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
[0] = KEYMAP(\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change KEYMAP to LAYOUT_all and its other references in the file

keyboards/al1/keymaps/splitbs/keymap.c
@@ -0,0 +1,56 @@
#include "al1.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to #include QMK_KEYBOARD_H

keyboards/al1/keymaps/splitbs/keymap.c
#include "al1.h"

const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
[0] = KEYMAP_SPLITBS(\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to LAYOUT_split_bs and its other references in this file too!

@drashna
Copy link
Member

drashna commented May 25, 2018

Is the custom matrix necessary here? If not, then it may be best to use the default one.

As for the bootloader, if you have a "RESET" code in the keymap, you should be okay.
Otherwise, make sure that BootMagic is enabled, as holding SPACE and B while plugging in the keyboard will jump to the bootloader, instead of QMK.
https://docs.qmk.fm/#/feature_bootmagic

drashna
drashna reviewed May 25, 2018
View reviewed changes
keyboards/al1/rules.mk

OPT_DEFS += -DINTERRUPT_CONTROL_ENDPOINT

OPT_DEFS += -DBOOTLOADER_SIZE=4096
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what controller is being used here?
Eg, is this a Pro Micro, Teensy 2.0, other, or SMD?

@drashna
Copy link
Member

drashna commented May 25, 2018

Could you make sure that the board has a readme?
https://docs.qmk.fm/#/documentation_templates?id=keyboard-readmemd-template

@drashna drashna mentioned this pull request Jul 7, 2018
Merged
@drashna
Copy link
Member

drashna commented Jul 7, 2018

#3330 supersedes this

@drashna drashna closed this Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@mechmerlin mechmerlin mechmerlin left review comments

Assignees
No one assigned
Labels
in progress keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olivia @drashna @mechmerlin